Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Thomas Orgis (6960e5e51b6035894de686ce270467a0c38445fb)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: seth AT swoolley.homeip.net
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Thomas Orgis (6960e5e51b6035894de686ce270467a0c38445fb)
  • Date: Tue, 5 Sep 2006 11:04:47 -0700

On Tue, Sep 05, 2006 at 08:00:38PM +0200, Arwed von Merkatz wrote:
> On Tue, Sep 05, 2006 at 10:14:08AM +0200, Thomas Orgis wrote:
> > Am Mon, 4 Sep 2006 20:14:23 +0200
> > schrieb Jaka Kranjc <lynx AT mages.ath.cx>:
> >
> > > > + ?config_query ?CREATE_DEV_TREE ?"check for / create static /dev
> > > > tree" y
> > > Shouldn't this query default to n, as most users do want udev?
> >
> > I tried not to change the logic of the spell: Formerly, it was
> >
> > if [ "$DEVICES" != "devfs" ]; then
> > check_static_dev
> > fi &&
> >
> > So both udev and static mode triggered the check_static_dev function,
> > while this function then asked for creation of the static tree,
> > defaulting to y.
> > What I did was to move that question out of the function and out of
> > INSTALL (!!) into the configure stage, but not changing default behaviour.
> > I must admit that I feel safer when there are some device nodes as
> > fallback even when using udev. It doesn't hurt, normally, but it
> > shouldn't be necessary.
> >
> > To change this default behaviour, that is a question that perhaps needs a
> > bit of discussion. When ppl agree, I'm not opposing.
>
> It defaults to yes because there were some install isos that installed a
> completely empty /dev directory and used devfs. You can't boot an udev
> system with such a /dev, so that check was added.

When we do hacks like this, it's god to put a little comment in that
says why we're doing something out of the ordinary. Other coders aren't
omniscient, and they can't read minds, either. ;)

>
> > > Also, it cuold be just me, but "check for/create static /dev tree" is
> > > more
> > > clear than "check for / create static /dev tree", I had no idea what it
> > > was
> > > asking me. Check for /, create static^C
> >
> > Agreed. I just didn't think of '/' being a term on its own, but in Unix
> > world it dead sure is!
> >
> >
> > Thomas.
> >
> > >
> > > --
> > > We cannot command nature except by obeying her. --Sir Francis Bacon
> > > Have a sourcerous day! www.sourcemage.org
> > _______________________________________________
> > SM-Commit mailing list
> > SM-Commit AT lists.ibiblio.org
> > http://lists.ibiblio.org/mailman/listinfo/sm-commit
> >
>
> --
> Arwed v. Merkatz Source Mage GNU/Linux
> developer
>
> http://www.sourcemage.org
> _______________________________________________
> SM-Commit mailing list
> SM-Commit AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-commit




Archive powered by MHonArc 2.6.24.

Top of Page