Source Mage code commit list

[Arwed von Merkatz <v.merkatz AT gmx.net>]

On Wed, Aug 09, 2006 at 01:05:23PM +0300, Juuso Alasuutari wrote:
> On Tuesday 08 August 2006 20:22, Arwed von Merkatz wrote:
> > On Tue, Aug 08, 2006 at 05:56:02AM -0500, Juuso Alasuutari wrote:
> > [...]
> >
> > > diff --git a/x11-toolkits/fltk/CONFIGURE b/x11-toolkits/fltk/CONFIGURE
> > > new file mode 100755
> > > index 0000000..333f175
> > > --- /dev/null
> > > +++ b/x11-toolkits/fltk/CONFIGURE
> > > @@ -0,0 +1,6 @@
> > > +config_query_option  FLTK_SHARED  "Build shared libraries?"  y  \
> > > +                     "--enable-shared"  "--disable-shared"      &&
> > > +config_query_option  FLTK_THREADS  "Enable multithreading support?"  n 
> > > \ +                     "--enable-threads"  "--disable-threads"         
> > >  
> > >  && +config_query_option  FLTK_XDBE  "Enable the X double-buffer
> > > extensions?"  n  \ +                     "--enable-xdbe" 
> > > "--disable-xdbe"
> >
> > We usually don't make the shared library query an option, mostly because
> > it rarely works correctly and other programs often expect shared libs.
> > Personally I wouldn't add those other two queries either, there's really
> > no reason to disable that stuff normally. And if a user wants to use
> > such specific options, there's the config_loc option in sorcery.
> 
> fltk's upstream defaults are to disable multithreading and dbe. Should the 
> spell nevertheless enforce '--enable-threads --enable-dbe', and how is this 
> compliant with our policies? If they would've been enabled by default I 
> probably wouldn't have bothered to add prompts in the first place. Same 
> goes 
> for the Xft stuff in DEPENDS.

If the upstream defaults are to disable the stuff, we should default
to that too (didn't notice the 'n' default in the queries). The question
to answer is why they are disabled by upstream. If it's because they're
unstable or cause problems, they probably shouldn't be options in the
spell. If it's just a matter of preference, they should stay.

-- 
Arwed v. Merkatz                              Source Mage GNU/Linux developer
                                                    http://www.sourcemage.org