Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Kevin Dahan (627b10e97eab2e6227affdc1bb63526e9f8162c3)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Flavien Bridault <vlaaad AT sourcemage.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Kevin Dahan (627b10e97eab2e6227affdc1bb63526e9f8162c3)
  • Date: Wed, 26 Jul 2006 12:50:23 +0200

Le mercredi 26 juillet 2006 à 05:18 -0500, Kevin Dahan a écrit :
> GIT changes to master grimoire by Kevin Dahan <unet AT sourcemage.org>:
<snip>
> diff --git a/audio-creation/csound5/DETAILS b/audio-creation/csound5/DETAILS
> new file mode 100755
> index 0000000..4c4db87
> --- /dev/null
> +++ b/audio-creation/csound5/DETAILS
> @@ -0,0 +1,18 @@
> + SPELL=csound5
> + VERSION=5.02.1
> + SOURCE=Csound${VERSION}_src.tar.gz
> + SOURCE2=Loris_STK_src-${VERSION}.zip
> +SOURCE_DIRECTORY=$BUILD_DIRECTORY/Csound${VERSION}
> + SOURCE_URL[0]=$SOURCEFORGE_URL/csound/$SOURCE
> + SOURCE2_URL[0]=$SOURCEFORGE_URL/csound/$SOURCE2
> +
> SOURCE_HASH=sha512:4997a83d1f53e9aedfc37f072abbc0fc5b4284620cb046f62f2c590d557fe1e6adef83785a8af70a7984cfbcb81913baffa51e7e4039cb0e06e00165fea2aac4
> +
> SOURCE2_HASH=sha512:f5e8c06756c47089a1524c342ee5505be7b13309bf5d41abdcfca297e1c69babb8b91f20b4614a1e994719e6e6a8082e84a3063b81a2b43c833d43d49b6f13a1
> + WEB_SITE=http://csound.sf.net
> + ENTERED=20050412
> + UPDATED=20050412
> + LICENSE[0]=GPL
> + BUILD_API=2
> + SHORT="new generation of the Csound language"
> +cat << EOF
> +Csound is a sound synthesis language.
> +EOF
<snip>

This file in not well formatted. I also noticed such problems in several
of your latest changes such as blop, timemachine, portaudio19, qjackctl,
ladcca (not formatted at all), lash, libmodplug, prokyon3 and possibly
others, I didn't check sooner than monday. Many are only a bad indent of
SOURCE_HASH, I suspect some bad joke of your favorite text editor ;-) Or
maybe use of a tab instead of spaces ?

Also, please avoid to add BUILD_API=2 and UPDATED in new spells.
BUILD_API 2 is the default and UPDATED is deprecated.
--
Flavien Bridault

Disk, Graphics, Graphics-libs sections Guru
Source Mage GNU/Linux - http://www.sourcemage.org

irc: vlaaad
jabber: vlaaad AT amessage.be

Attachment: signature.asc
Description: Ceci est une partie de message numériquement signée




Archive powered by MHonArc 2.6.24.

Top of Page