Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (1e4a7af5c4c264381a5131f42c2c2c4a52960476)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Arwed von Merkatz <v.merkatz AT gmx.net>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (1e4a7af5c4c264381a5131f42c2c2c4a52960476)
  • Date: Mon, 26 Jun 2006 08:19:53 +0200

On Sun, Jun 25, 2006 at 07:07:59PM +0200, Treeve Jelbert wrote:
> On Sunday 25 June 2006 18:42, Arwed von Merkatz wrote:
> > On Sun, Jun 25, 2006 at 11:23:01AM -0500, Treeve Jelbert wrote:
> > > +diff -uNr libexif-0.6.13/libexif/libexif.pc.in
> > > libexif-0.6.13.orig/libexif/libexif.pc.in +---
> > > libexif-0.6.13/libexif/libexif.pc.in 2005-03-17 16:58:18.000000000
> > > +0100
> > > ++++ libexif-0.6.13.orig/libexif/libexif.pc.in 2006-06-25
> > > 15:12:26.000000000 +0200 +@@ -8,4 +8,4 @@
> > > + Requires:
> > > + Version: @VERSION@
> > > + Libs: -L${libdir} -lexif -lm
> > > +-Cflags: -I${includedir}
> > > ++Cflags: -I${includedir}/libexif
> >
> > This change is wrong, the correct CFLAGS for libexif are
> > -I${includedir}, since the correct way to use it is to #include
> > <libexif/whatever.h>, every spell depending on it on my system uses it
> > like that.
>
>
> I did think of that but it means passing LIBEXIF_CFLAGS to make, not CFLAGS.
>
> I built libgphoto2 against the modified libexif, but I will revert the
> change
> and patch the other spell

Stuff probably builds fine with the changed Cflags, as the correct
includedir is -I/usr/include, which is searched by default, but I prefer
keeping the .pc files correct.

--
Arwed v. Merkatz Source Mage GNU/Linux developer
http://www.sourcemage.org




Archive powered by MHonArc 2.6.24.

Top of Page