Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master z-rejected grimoire by Daniel Goller (6f075449006106d2ba47321e704007eb887b6620)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master z-rejected grimoire by Daniel Goller (6f075449006106d2ba47321e704007eb887b6620)
  • Date: Fri, 23 Jun 2006 11:03:26 +0200

On Friday 23 June 2006 01:16, Daniel Goller wrote:
> diff --git a/z-ftp/azureus-bin/DEPENDS b/z-ftp/azureus-bin/DEPENDS
> index 6d655e6..5e07431 100755
> --- a/z-ftp/azureus-bin/DEPENDS
> +++ b/z-ftp/azureus-bin/DEPENDS
> @@ -1 +1 @@
> -depends JAVA
> +config_query_list JAVA "Which Java do you want ?" jdk1.5-bin jre1.5-bin
Where is the depends? You only query and set a variable (which should be done
in CONFIGURE anyway). I'd move it, change the variable name to A_JAVA or
something that can't be mistaken for the provider and then add
if [[ $A_JAVA == jdk1.5-bin ]]; then
depends jdk1.5-bin
else
depends jre1.5-bin
fi

> diff --git a/z-ftp/azureus-bin/DETAILS b/z-ftp/azureus-bin/DETAILS
> index e9a3479..3dd5e57 100755
> --- a/z-ftp/azureus-bin/DETAILS
> +++ b/z-ftp/azureus-bin/DETAILS
> @@ -1,9 +1,9 @@
> SPELL=azureus-bin
> PKGNAME=Azureus
> VERSION=2.4.0.2
> -if [ "$AZUREUS_BIN_GTK" == "y" ]; then
> - SOURCE=${PKGNAME}_${VERSION}_linux.tar.bz2
> -
> SOURCE_HASH=sha512:91f4e3848d9807d8dbc055b8c55b03ff64ff52451d5a10c9b7066412
>6d77f01d035f864b71e49152b13cbeabe8ad75ff2aaa4a0011c7ff1b0a1e82ffe56cf569 +if
> [[ "${HOST%%-*}" == 'x86_64' ]]; then
> + SOURCE=${PKGNAME}_${VERSION}_linux-x86_64.tar.bz2
> +
The proper way is to check ${SMGL_COMPAT_ARCHS[1]}, not $HOST. I don't know
exactly why, but that's how we do it. Probably more robust.
$ ls /usr/share/archspecs # the 0 element
32 64 null
$ ls /usr/share/archspecs/64 # the 1 element
ppc sparc x86_64
...

> SOURCE_HASH=sha512:cdf00b1dcbb3c4377c5063e5829bc2cf0bcbd519c7278f2cd120dd90
>9e06c74e08dd47496453f18d422b95c264fdeb66f552e401cb79d1389165f7fab3c84302
> else
> SOURCE=${PKGNAME}_${VERSION}_linux.tar.bz2
>
> SOURCE_HASH=sha512:91f4e3848d9807d8dbc055b8c55b03ff64ff52451d5a10c9b7066412
>6d77f01d035f864b71e49152b13cbeabe8ad75ff2aaa4a0011c7ff1b0a1e82ffe56cf569 @@
> -14,7 +14,7 @@ SOURCE_DIRECTORY=$BUILD_DIRECTORY/azureu
> LICENCE[0]=GPL
> WEB_SITE=http://azureus.sourceforge.net
> ENTERED=20041128
> - UPDATED=20050212
> + UPDATED=20060612
UPDATED is getting deprecated, if you want to force a recompile/queueing for
the users, increase/add PATCHLEVEL. UPDATED still works though, but imho this
change doesn't require a change in either.
(UPDATED is not used for logging, we have HISTORY for that)

--
We cannot command nature except by obeying her. --Sir Francis Bacon

Attachment: pgpVvCb9cpbkv.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page