Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 80435 by Jason Flatt for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: SM-Commit <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] PERFORCE change 80435 by Jason Flatt for review
  • Date: Fri, 09 Jun 2006 13:48:29 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jason Flatt wrote:
> On Friday 09 June 2006 12:40, Eric Sandall wrote:
>> Perforce Review Daemon wrote:
>>> Change 80435 by jason_flatt@jason-jason on 2006/06/09 20:10:36
>>>
>>> New spell: f4l
>>>
>>> Affected files ...
>>>
>>> ... //sgl/grimoires/test/ChangeLog#305 edit
>>>
>>> Differences ...
>>>
>>> ==== //sgl/grimoires/test/ChangeLog#305 (text) ====
>>>
>>> @@ -1,3 +1,6 @@
>>> +2006-06-09 Jason Flatt <jflatt AT sourcemage.org>
>>> + * kde-apps/f4l: new spell, flash editor for linux
>>> +
>> <snip>
>>
>> This looks like it was a direct edit of the ChangeLog in test rather
>> than an integrate of the change in devel's ChangeLog...
>>
>> -sandalle
>
> I didn't put it into devel. I modified what was already in devel and
> integrated into test (where it did not previously exist). I ASSuMEd that
> the
> ChangeLog entry was already in devel and only changed the test ChangeLog.
> Was
> that the wrong way of doing it?

Partially. The proper way is to integrate the change from devel to test
(so you'd need to use `p4 filelog devel/ChangeLog` and find where the
entry was made).

- -sandalle

- --
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us | http://www.sourcemage.org/
http://eric.sandall.us/ | SysAdmin @ Shock Physics @ WSU
http://counter.li.org/ #196285 | http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEid6dHXt9dKjv3WERAu2KAJ0dR4JL9/6NlaCMExk8zMnWBhBlBACgi1cI
mBYJR08wA32Yhq5k+Nyp9uo=
=QdNa
-----END PGP SIGNATURE-----




Archive powered by MHonArc 2.6.24.

Top of Page