Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to test grimoire by Robin Cook

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Arwed von Merkatz <v.merkatz AT gmx.net>
  • To: SM-Commit Daemon <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to test grimoire by Robin Cook
  • Date: Tue, 23 May 2006 18:02:34 +0200

On Tue, May 23, 2006 at 08:45:06AM -0700, Eric Sandall wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Arwed von Merkatz wrote:
> > On Mon, May 22, 2006 at 04:46:00PM -0500, Robin Cook wrote:
> >> GIT changes to test grimoire by Robin Cook <rcook AT wyrms.net>:
> > [...]
> >> diff --git a/gnome2-apps/API_VERSION b/gnome2-apps/API_VERSION
> >> new file mode 100755
> >> index 0000000..844885a
> >> --- /dev/null
> >> +++ b/gnome2-apps/API_VERSION
> >> @@ -0,0 +1 @@
> >> +BUILD_API=2
> >> diff --git a/gnome2-apps/FUNCTIONS b/gnome2-apps/FUNCTIONS
> >> new file mode 100755
> >> index 0000000..1abeab6
> >> --- /dev/null
> >> +++ b/gnome2-apps/FUNCTIONS
> >> @@ -0,0 +1,15 @@
> >> +#---------------------------------------------------------------------
> >> +## Replaces sorcerys default_pre-remove with a custom version
> >> +#---------------------------------------------------------------------
> >> +function default_pre_remove() {
> >> + debug "libapi" "$FUNCNAME - $*"
> >> + real_default_pre_remove "$@"
> >> + if [ -f "${SCRIPT_DIRECTORY}/G_SCHEMAS" ]; then
> >> + local G_FILE
> >> + export
> >> GCONF_CONFIG_SOURCE="xml:readwrite:${INSTALL_ROOT}/etc/gconf/gconf.xml.defaults"
> >> + for G_FILE in `cat ${SCRIPT_DIRECTORY}/G_SCHEMAS`
> >> + do
> >> + gconftool-2 --makefile-uninstall-rule
> >> "${INSTALL_ROOT}/etc/gconf/schemas/${G_FILE}"
> >> + done
> >> + fi
> >> +}
> >
> > Could we make this > /dev/null please? Right now, when you dispel two
> > spells that use this, the screen gets filled with stuff about schemas
> > and you never see sorcerys message about the spells being dispelled.
> >
>
> I think it'd be better if we could send that output to a log (even if
> the debug log) rather than /dev/null.

Something like that would be ok with me, though that output isn't very
interesting in any case imho. Since it would be only '> somewhere', any
errors would still be visible.
Outputting this stuff to stdout really serves no purpose, as dispel
doesn't create logs like cast does.

--
Arwed v. Merkatz Source Mage GNU/Linux developer
http://www.sourcemage.org




Archive powered by MHonArc 2.6.24.

Top of Page