sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] PERFORCE change 79538 by David Kowis for review
- From: David Kowis <dkowis AT shlrm.org>
- To: Ladislav Hagara <ladislav.hagara AT unob.cz>
- Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, Andrew Stitt <a AT thefrayedknot.armory.com>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Arjan Bouter <abouter AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>
- Subject: Re: [SM-Commit] PERFORCE change 79538 by David Kowis for review
- Date: Mon, 22 May 2006 07:13:12 -0500
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Ladislav Hagara wrote:
>> Change 79538 by david_kowis@dkowis-kain on 2006/05/19 21:34:41
>>
>> Fixed a permissions evilness in FUNCTIONS install_www_files
>>
>> Affected files ...
>>
>> ... //sgl/grimoires/devel/ChangeLog#331 edit
>> ... //sgl/grimoires/devel/FUNCTIONS#35 edit
>>
>> Differences ...
>>
>> ==== //sgl/grimoires/devel/ChangeLog#331 (text) ====
>>
>> @@ -3,6 +3,8 @@
>>
>> 2006-05-19 David Kowis <dkowis AT shlrm.org>
>> * FUNCTIONS: Added a function to get at the install_www_files location
>> + Also fixed some permissions mangling
>> + * perl-cpan/cgi-speedycgi: perlmodule to persist perl scripts
>>
>> ==== //sgl/grimoires/devel/FUNCTIONS#35 (xtext) ====
>>
>> @@ -241,7 +241,7 @@
>> # find $1 -type -f | while read file; do
>> for www_file in `find $1 -type f`; do
>> if install_config_file "$www_file" "$WWW_DEST/$www_file"; then
>> - chmod 0644 "$WWW_DEST/$www_file" &&
>> + chmod u+r,g+r,o-wx "$WWW_DEST/$www_file" &&
>
> What was wrong with 0664?
> It seems hazardously for me.
>
We probably shouldn't be modifying the permissions at all. Setting 0644
clobbers any executables that may be in a cgi-bin folder. This way
ensures that only the www-data user/group can execute and write the
files without removing the executable flag.
- --
David Kowis
ISO Team Lead - www.sourcemage.org
Source Mage GNU/Linux
Progress isn't made by early risers. It's made by lazy men trying to
find easier ways to do something.
- Robert Heinlein
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
iQGVAwUBRHGq2Mnf+vRw63ObAQonjwwAp+Kr6/7brQZsAa5c+yOCikJQ81q+qwOH
+rU/yD3cew4aH/t0VIi+DTHX9yJxIFR5C2JeuUgDh8DyweSzjEGh4C4wBBJE4gsR
uzFSNFWhspbpndtfb/kwLYH77F0y2X+kGG3+xSqH10fFJVxX26WWS2yGKKMnLENg
abKANN23yCEFnKX/rxEpns97OE4dwKGoT5BwigBAVdkyVno2MUtSkh5nEemUh5D/
8H1P1xhIJF8gFsVoQbOSu8ED5g3WoVoRISiei3TVESALVvZ5z/yy7rZ0tgCc8SC+
usIsUZ1pk4A8brGkA4Q4o//bX0tJsiKHHgMdt4MpO9BBdVj2D8qCv25BiU9xvUZg
Or+l67Cz6mkNEp8rYnLypoMPC2nZK+4OZdnUurWKu9ffJyr82E2myxWsyegATkwc
DG1wmI9zdaeS6MeFjq8+oO0MZK5JpxI6TQIpMAlsL1J6JWparxXlO61PzL9Uedgb
scuvg+Y5Mqdrr+7YkRt8DiD/BToqvO/D
=7ESB
-----END PGP SIGNATURE-----
-
[SM-Commit] PERFORCE change 79538 by David Kowis for review,
Perforce Review Daemon, 05/19/2006
- Re: [SM-Commit] PERFORCE change 79538 by David Kowis for review, Eric Sandall, 05/19/2006
-
Re: [SM-Commit] PERFORCE change 79538 by David Kowis for review,
Ladislav Hagara, 05/21/2006
- Re: [SM-Commit] PERFORCE change 79538 by David Kowis for review, David Kowis, 05/22/2006
Archive powered by MHonArc 2.6.24.