Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 78913 by Arwed von Merkatz for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Arwed von Merkatz <v.merkatz AT gmx.net>
  • To: SM-Commit Daemon <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] PERFORCE change 78913 by Arwed von Merkatz for review
  • Date: Sat, 6 May 2006 22:48:49 +0200

On Sat, May 06, 2006 at 01:45:11PM -0700, Eric Sandall wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Perforce Review Daemon wrote:
> > Change 78913 by arwed_von_merkatz@arwed-Otherland on 2006/05/06 13:14:14
> >
> > set QTDIR, fixes bug #11763
> >
> > Affected files ...
> >
> > ... //sgl/grimoires/devel/video/mythtv/BUILD#5 edit
> > ... //sgl/grimoires/devel/video/mythtv/HISTORY#16 edit
> >
> > Differences ...
> >
> > ==== //sgl/grimoires/devel/video/mythtv/BUILD#5 (xtext) ====
> >
> > @@ -1,6 +1,7 @@
> > #sedit "s:/usr/local:$INSTALL_ROOT/usr:" configure &&
> > #sedit "s:/usr/local:$INSTALL_ROOT/usr:" settings.pro &&
> > invoke_gcc
> > +QTDIR=${QTDIR:-$INSTALL_ROOT/usr} &&
> > ./configure --prefix=/usr $OPTS &&
> > qmake mythtv.pro &&
> > make
> <snip>
>
> Shouldn't this instead source $TRACK_ROOT/etc/profile.d/qt.sh?

I thought about that for a bit and I'm really not sure what the sanest
way is.
It could get the value from TRACK_ROOT, then prepend INSTALL_ROOT
because it should be built against the one in INSTALL_ROOT, whatever it
later uses. I figured with what I added, it should work in most cases,
even in the case a user installs his own qt, as it prefers the set value
of QTDIR. The whole TRACK_ROOT/INSTALL_ROOT business is still not really
100% clear, we should take a very close look at the various use cases
once we have sorcery with stage_root support.
As it is, my primary concern was to get it working in the use-case that
a normal system without INSTALL_ROOT or TRACK_ROOT set casts mythtv
without having qt-x11 installed, so that's what I fixed ;)

--
Arwed v. Merkatz Source Mage GNU/Linux developer
http://www.sourcemage.org




Archive powered by MHonArc 2.6.24.

Top of Page