sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Re: [SM-Commit] PERFORCE change 78835 by Matthew Clark for review

From: Matthew Clark <MatthewClark AT InLesserTerms.net>
To: Andrew Stitt <a AT t.armory.com>, Arjan Bouter <abouter AT sourcemage.org>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, duane_malcolm <d.malcolm AT auckland.ac.nz>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>, Maurizio Boriani <baux AT member.fsf.org>, Pieter Lenaerts <e-type AT sourcemage.org>, Robin Cook <rcook AT wyrms.net>, Seth Woolley <seth AT swoolley.homeip.net>, Unet <unet AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>
Subject: Re: [SM-Commit] PERFORCE change 78835 by Matthew Clark for review
Date: Tue, 02 May 2006 12:49:38 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ah, okay. Thanx!

- - Matt

Arwed von Merkatz wrote:
> On Tue, May 02, 2006 at 06:35:01PM +0100, Perforce Review Daemon wrote:
>> Change 78835 by matthew_clark@mclark-aussie on 2006/05/02 18:31:28
>>
>> I guess I forgot to submit this yesterday. Fixing bug 11285.
>>
>> Affected files ...
>>
>> ... //sgl/grimoires/devel/net/isic/DEPENDS#1 add
>> ... //sgl/grimoires/devel/net/isic/HISTORY#5 edit
>>
>> Differences ...
>>
>> ==== //sgl/grimoires/devel/net/isic/HISTORY#5 (text) ====
>>
>> @@ -1,3 +1,7 @@
>> +2006-05-01 Matthew Clark <matthewclark AT inlesserterms.net>
>> + * Fixing bug 11285
>> + * DEPENDS Added libnet dependency
>> +
>
> Just a matter of style, the usual way of adding such entries would be:
> 2006-05-01 ...
> * DEPENDS: Added libnet dependency, fixes bug #11285
>
> That way it's more obvious what changes are related to fixing a bug and
> what were just unrelated changes in bigger commits.
>
>> 2006-03-12 Karsten Behrmann <BearPerson AT sourcemage.org>
>> * DETAILS: (automated) Add KEYWORDS
>>
>> _______________________________________________
>> SM-Commit mailing list
>> SM-Commit AT lists.ibiblio.org
>> http://lists.ibiblio.org/mailman/listinfo/sm-commit
>>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEV5uy7vwGAOVJvJ8RAiE/AKDOq8CdCo/qcv0lWvje2+dTDhsP3gCgsShi
R09FUaaG9B4OVz/Y2uemDds=
=ZAAV
-----END PGP SIGNATURE-----

[SM-Commit] PERFORCE change 78835 by Matthew Clark for review, Perforce Review Daemon, 05/02/2006
- Re: [SM-Commit] PERFORCE change 78835 by Matthew Clark for review, Arwed von Merkatz, 05/02/2006
  - Re: [SM-Commit] PERFORCE change 78835 by Matthew Clark for review, Matthew Clark, 05/02/2006