Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 78782 by Juuso Alasuutari for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: "Andraž \"ruskie\" Levstik" <ruskie AT mages.ath.cx>
  • To: Juuso Alasuutari <iuso AT sourcemage.org>
  • Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Andrew Stitt <a AT t.armory.com>, Arjan Bouter <abouter AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>
  • Subject: Re: [SM-Commit] PERFORCE change 78782 by Juuso Alasuutari for review
  • Date: Tue, 2 May 2006 11:40:36 +0200

Perforce Review Daemon wrote :

> Change 78782 by juuso_alasuutari@juuso_alasuutari-kamayuq on 2006/05/02
> 00:37:15
>
> Don't install modprobe.conf for udev, let udev mind its
> own business. This is WIP until udev can also be integrated to
> test at the same time.
>
> Affected files ...
>
> ... //sgl/grimoires/devel/kernels/module-init-tools/DETAILS#13 edit
> ... //sgl/grimoires/devel/kernels/module-init-tools/HISTORY#23 edit
> ... //sgl/grimoires/devel/kernels/module-init-tools/INSTALL#6 edit
> ... //sgl/grimoires/devel/kernels/module-init-tools/WIP#3 add
> ... //sgl/grimoires/devel/kernels/module-init-tools/modprobe.conf#2 delete
>
> Differences ...
>
> ==== //sgl/grimoires/devel/kernels/module-init-tools/DETAILS#13 (xtext) ====
>
> @@ -16,7 +16,7 @@
>
> SPELL=module-init-tools
> VERSION=3.2.2
> - PATCHLEVEL=2
> + PATCHLEVEL=1
> BUILD_API=2
> SOURCE=$SPELL-$VERSION.tar.bz2
> SOURCE_DIRECTORY=$BUILD_DIRECTORY/$SPELL-$VERSION
>
> ==== //sgl/grimoires/devel/kernels/module-init-tools/HISTORY#23 (text) ====
>
> @@ -1,3 +1,9 @@
> +2006-04-30 Juuso Alasuutari <iuso AT sourcemage.org>
> + * INSTALL: Removed install of modprobe.conf with aliases, udev
> + spell will take care of this
> + * modprobe.conf: Deleted
> + * DETAILS: PATCHLEVEL
> +
> 2006-04-28 Jeremy Blosser <jblosser-smgl AT firinn.org>
> * PREPARE, UP_TRIGGERS: Make sure
> $INSTALL_ROOT/etc/sysconfig/facilities exists before grepping it.
>
> ==== //sgl/grimoires/devel/kernels/module-init-tools/INSTALL#6 (xtext) ====
>
> @@ -20,5 +20,4 @@
> ./generate-modprobe.conf ${INSTALL_ROOT}/etc/modprobe.conf
> fi &&
>
> -install_config_file modprobe.devfs ${INSTALL_ROOT}/etc/modprobe.devfs &&
> -install_config_file $SCRIPT_DIRECTORY/modprobe.conf
> $INSTALL_ROOT/etc/modprobe.conf
> +install_config_file modprobe.devfs ${INSTALL_ROOT}/etc/modprobe.devfs
> _______________________________________________
> SM-Commit mailing list
> SM-Commit AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-commit
>
>

I don't agree with removing the modprob.conf FROM the module-init-tools
spell.

This makes it BROKEN for everbody NOT using udev.

Try to use the include's and so on...and install a default
modprobe.conf that includes in the proper order....

--
Andraž "ruskie" Levstik
Source Mage GNU/Linux Games grimoire guru
Geek/Hacker/Tinker

Hacker FAQ: http://www.plethora.net/%7eseebs/faqs/hacker.html

Key id = A7A9E461
Key fingerprint = 757E C16B F5B7 DC27 B003 CCED CF95 3A77 A7A9 E461





Archive powered by MHonArc 2.6.24.

Top of Page