sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Re: [SM-Commit] PERFORCE change 78650 by David C. Haley for review

From: seth AT swoolley.homeip.net
To: "David C.Haley" <dhaley AT hot.rr.com>
Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>, Andrew Stitt <a AT thefrayedknot.armory.com>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Ladislav Hagara <ladislav.hagara AT unob.cz>, Arjan Bouter <abouter AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>
Subject: Re: [SM-Commit] PERFORCE change 78650 by David C. Haley for review
Date: Sat, 29 Apr 2006 23:05:50 -0700

Nothing against David, but, I think I should mention for everybody...

While the history doesn't mention why the autogen.sh part was added,
it's good to check to make sure that autogen.sh isn't truly needed to
clean up the build system from older build setups. There are a few
cases when this is needed:

1) there was a bug in some build setups that caused g++ to be required
when it wasn't really needed

2) some platforms are newer than the build system and need at least
patching (like x86_64).

Perhaps some other issues as well.

So, developers, 1) remember to document why you make changes to build
systems and 2) when you think it's not needed anymore, make sure to test
it against those same reasons.

This case, unfortunately, wasn't documented, and it happened back four
years ago, so until this is tested for the two issues above, we should
be careful integrating it to stable. :)

Seth

On Sun, Apr 30, 2006 at 05:15:01AM +0100, Perforce Review Daemon wrote:
> Change 78650 by david_haley@david-grimoire on 2006/04/30 05:10:38
>
> The updates to the BUILD/PRE_BUILD files that was implemented in
> devel are being pushed to test.
> I did not have any problems with this on my own machine and they are
> rather small changes.
>
> Affected files ...
>
> ... //sgl/grimoires/test/libs/libfwbuilder/HISTORY#10 integrate
> ... //sgl/grimoires/test/libs/libfwbuilder/PRE_BUILD#1 branch
> ... //sgl/grimoires/test/net/fwbuilder/HISTORY#10 integrate
> ... //sgl/grimoires/test/net/fwbuilder/PRE_BUILD#1 branch
>
> Differences ...
>
> ==== //sgl/grimoires/test/libs/libfwbuilder/HISTORY#10 (text) ====
>
> @@ -1,3 +1,7 @@
> +2006-04-29 David C. Haley <dhaley AT hot.rr.com>
> + * PRE_BUILD: Created
> + * BUILD: autogen.sh and make removed; default_build added
> +
> 2006-04-27 David C. Haley <dhaley AT hot.rr.com>
> * DETAILS: upgrade to 2.0.12
>
>
> ==== //sgl/grimoires/test/net/fwbuilder/HISTORY#10 (text) ====
>
> @@ -1,3 +1,7 @@
> +2006-04-29 David C. Haley <dhaley AT hot.rr.com>
> + *PRE_BUILD: Created
> + *BUILD: autogen.sh and make lines removed
> +
> 2006-04-27 David C. Haley <dhaley AT hot.rr.com>
> * DETAILS: upgrade to 2.0.12
>

[SM-Commit] PERFORCE change 78650 by David C. Haley for review, Perforce Review Daemon, 04/30/2006
- Re: [SM-Commit] PERFORCE change 78650 by David C. Haley for review, seth, 04/30/2006