Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 77789 by David Michael Leo Brown Jr. for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: "David Brown" <dmlb2000 AT gmail.com>
  • To: "David Michael Leo Brown Jr." <dmlb2000 AT gmail.com>
  • Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>, Eric Sandall <eric AT sandall.us>, vladimir_marek <vlmarek AT volny.cz>, Juuso Alasuutari <iuso AT sourcemage.org>, Pol Vinogradov <vin.public AT gmail.com>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Andrew Stitt <a AT t.armory.com>, Arjan Bouter <abouter AT sourcemage.org>, Ladislav Hagara <ladislav.hagara AT unob.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Seth Woolley <seth AT swoolley.homeip.net>
  • Subject: Re: [SM-Commit] PERFORCE change 77789 by David Michael Leo Brown Jr. for review
  • Date: Fri, 14 Apr 2006 14:41:40 -0700

On 4/14/06, Perforce Review Daemon <p4review AT smee.org> wrote:
> Change 77789 by david_brown@dmlb2000-dmlb2004 on 2006/04/14 22:34:40
>
> this is kinda a specific one
> http://wiki.kernelnewbies.org/LinuxChanges says that on 2.6.16 the
> ppc
> architecture changes slightly and apparently it causes some stuff to
> fail if you don't specify ARCH=powerpc vs. ARCH=ppc so I removed the
> ARCH specification from all the make calls so the kernel can figure
> it
> out by itself, this needs to be tested to make sure the rest of the
> spell works.

I would like to know if people with powerpc's would help in testing
this (considering I don't have access to one really) especially new
world to make sure it works.

> PRE_BUILD the change on 4-10 was done improperly if expert mode
> directory doesn't exist we can't go to newktree because that
> wouldn't
> work so we have to return 1 if mode is anything else we change to
> newktree
>
> Affected files ...
>
> ... //sgl/grimoires/devel/kernels/linux/BUILD#9 edit
> ... //sgl/grimoires/devel/kernels/linux/HISTORY#283 edit
> ... //sgl/grimoires/devel/kernels/linux/INSTALL#9 edit
> ... //sgl/grimoires/devel/kernels/linux/PRE_BUILD#22 edit
>
> Differences ...
>
> ==== //sgl/grimoires/devel/kernels/linux/BUILD#9 (xtext) ====
>
> @@ -14,18 +14,18 @@
> case "$VERSION" in
> 2.6*)
> echo "making for a 2.6 kernel" &&
> - ARCH="$kernel_arch" make $EXTRA_MAKE_OPTIONS || return 1
> + make $EXTRA_MAKE_OPTIONS || return 1
> ;;
> 2.[024]*)
> echo "making for a 2.4 kernel" &&
> - ARCH="$kernel_arch" make dep &&
> + make dep &&
> case $kernel_arch in
> - sparc*) ARCH="$kernel_arch" make $EXTRA_MAKE_OPTIONS vmlinux ||
> return 1 ;;
> - ppc) ARCH="$kernel_arch" make $EXTRA_MAKE_OPTIONS vmlinux ||
> return 1 ;;
> - sh) ARCH="$kernel_arch" make $EXTRA_MAKE_OPTIONS zImage ||
> return 1 ;;
> - *) ARCH="$kernel_arch" make $EXTRA_MAKE_OPTIONS bzImage ||
> return 1 ;;
> + sparc*) make $EXTRA_MAKE_OPTIONS vmlinux || return 1 ;;
> + ppc) make $EXTRA_MAKE_OPTIONS vmlinux || return 1 ;;
> + sh) make $EXTRA_MAKE_OPTIONS zImage || return 1 ;;
> + *) make $EXTRA_MAKE_OPTIONS bzImage || return 1 ;;
> esac &&
> - ARCH="$kernel_arch" make $EXTRA_MAKE_OPTIONS modules || return 1
> + make $EXTRA_MAKE_OPTIONS modules || return 1
> ;;
> *)
> echo "There is no kernel version: $VERSION" &&
>
> ==== //sgl/grimoires/devel/kernels/linux/HISTORY#283 (text) ====
>
> @@ -1,3 +1,13 @@
> +2006-04-14 David Brown <dmlb2000 AT gmail.com>
> + * PRE_BUILD: removed references to ARCH=kernel_arch see
> + http://wiki.kernelnewbies.org/LinuxChanges for 2.6.16 as to why
> + specifically the PPC section
> + also change on 4-10 wasn't done right, expert mode should return
> an
> + error if the directory doesn't exist but if mode doesn't exist it
> + should go to newktree
> + * BUILD: same as PRE_BUILD as to kernel arch
> + * INSTALL: same as BUILD
> +
> 2006-04-13 David Brown <dmlb2000 AT gmail.com>
> * latest.defaults: updated latest to patch-2.6.16-cks5
> * info/patches/ck_server_patches/patch-2.6.16-cks5: added
>
> ==== //sgl/grimoires/devel/kernels/linux/INSTALL#9 (xtext) ====
>
> @@ -6,7 +6,7 @@
> case "$VERSION" in
> 2.[0246]*)
> message "${MESSAGE_COLOR}installing for a
> 2.x kernel${DEFAULT_COLOR}" &&
> - ARCH="$kernel_arch" make
> INSTALL_MOD_PATH="${INSTALL_ROOT}" modules_install
> + make INSTALL_MOD_PATH="${INSTALL_ROOT}"
> modules_install
> ;;
> *)
> message "${PROBLEM_COLOR}I again don't know
> what version: $VERSION is${DEFAULT_COLOR}" &&
>
> ==== //sgl/grimoires/devel/kernels/linux/PRE_BUILD#22 (xtext) ====
>
> @@ -37,13 +37,13 @@
> then
> message "${MESSAGE_COLOR}Using
> ${LINUX_SOURCE_DIRECTORY} for expert build${DEFAULT_COLOR}"
> else
> - message "${PROBLEM_COLOR}Ah
> ${LINUX_SOURCE_DIRECTORY} isn't set properly going to
> newktree${DEFAULT_COLOR}"
> - mode="newktree"
> + message "${PROBLEM_COLOR}Ah
> ${LINUX_SOURCE_DIRECTORY} doesn't exist exiting${DEFAULT_COLOR}"
> + return 1
> fi
> ;;
> *)
> - message "${PROBLEM_COLOR}Ah, don't know what ${mode} is
> exiting${DEFAULT_COLOR}"
> - return 1
> + message "${PROBLEM_COLOR}Ah ${LINUX_SOURCE_DIRECTORY} isn't
> set properly going to newktree${DEFAULT_COLOR}"
> + mode="newktree"
> ;;
> esac
>
> @@ -131,7 +131,7 @@
> MENUCONFIG_EXIT="n" &&
> while [[ "$MENUCONFIG_EXIT" == "n" ]]
> do
> - ARCH=${kernel_arch} make $MAKEMODE &&
> + make $MAKEMODE &&
> if query "Do you really want to exit
> menuconfig?" y
> then
> MENUCONFIG_EXIT="y"
> @@ -144,7 +144,7 @@
> yes '' | make oldconfig
> ;;
> *)
> - ARCH=${kernel_arch} make $MAKEMODE
> + make $MAKEMODE
> esac
> else
> case "$MAKEMODE" in
>




Archive powered by MHonArc 2.6.24.

Top of Page