Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 77640 by John Harding for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: "Jeremy Blosser (emrys)" <jblosser-smgl AT firinn.org>
  • To: SM-Commit Daemon <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] PERFORCE change 77640 by John Harding for review
  • Date: Thu, 13 Apr 2006 18:05:58 -0500

On Apr 12, Perforce Review Daemon [p4review AT smee.org] wrote:
> Change 77640 by john_harding@john_harding-iowa1000 on 2006/04/12 15:43:13
>
> Almost forgot the history entry for the api2 conversion

> Affected files ...
>
> ... //sgl/grimoires/games/games-rpg-mp/tinyfugue/HISTORY#4 edit
>
> Differences ...
>
> ==== //sgl/grimoires/games/games-rpg-mp/tinyfugue/HISTORY#4 (text) ====
>
> @@ -1,3 +1,11 @@
> +2006-04-12 John Harding <johnh AT kuberaconsulting.com>
> + * DETAILS: Allow for installing either Stable or Experimental
> + * DEPENDS: gcc34 for stable
> + * PRE_BUILD: Placed sedits in here for Stable api2
> + * BUILD: Modified to support Stable and Experimental
> + * INSTALL: Added to handle Stable
> + * CONFIGURE: Added to allow choice between Stable and Experimental

Thanks, some comments...

The query in CONFIGURE should be in PREPARE.
http://wiki.sourcemage.org/PREPARE

The query has the right default (stable), but the logic in DETAILS does 'if
stable is set, else use experimental. This makes experimental the default
apart from the query, and can be confusing ('gaze version tinyfugue' if it
isn't installed will show 5.x as the available version).

I'd suggest using variable values 'stable' and 'experimental' (or just
'devel') instead of using 'Stable-40s1' and 'Experimental-50b7'. With what
you have now you have to change those strings every time a version changes
instead of just changing the one version listed in DETAILS. It's also
non-standard.

Attachment: pgp9tVQPQDAaH.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page