Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 76952 by Juuso Alasuutari for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Arwed von Merkatz <v.merkatz AT gmx.net>
  • To: Juuso Alasuutari <iuso AT sourcemage.org>, Andraž ruskie Levstik <ruskie AT mages.ath.cx>, Andrew Stitt <a AT t.armory.com>, Arjan Bouter <abouter AT gmail.com>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, David Kowis <dkowis+smgl-p4 AT shlrm.org>, duane_malcolm <d.malcolm AT auckland.ac.nz>, Eric Sandall <eric AT sandall.us>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>, "George J. Sherwood" <george AT beernabeer.com>, Jason Flatt <jflatt AT sourcemage.org>, Ladislav Hagara <ladislav.hagara AT unob.cz>, Maurizio Boriani <baux AT member.fsf.org>, Pieter Lenaerts <e-type AT sourcemage.org>, Pol Vinogradov <vin.public AT gmail.com>, Robin Cook <rcook AT wyrms.net>, Unet <unet AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>
  • Subject: Re: [SM-Commit] PERFORCE change 76952 by Juuso Alasuutari for review
  • Date: Wed, 29 Mar 2006 10:27:40 +0200

On Wed, Mar 29, 2006 at 02:20:31AM -0600, Jeremy Blosser wrote:
> On Mar 29, Perforce Review Daemon [p4review AT smee.org] wrote:
> > Change 76952 by juuso_alasuutari@juuso_alasuutari-kamayuq on 2006/03/29
> > 09:06:32
> >
> > removed dnotify query && made dnotify always on in kde spells
>
> Why? Is there a bug related to the need for this?

It's been discussed on irc a couple of times. There is absolutely no
reason to have this as an option. dnotify is always available on
anything > kernel 2.2 and should just be used. Unless they did something
weird in kde it won't break if it's not available in the kernel either.

> > Affected files ...
> >
> > ... //sgl/grimoires/devel/ChangeLog#273 edit
> > ... //sgl/grimoires/devel/kde-core/KDE_BUILD#5 edit
> > ... //sgl/grimoires/devel/kde-core/KDE_CONFIGURE#4 edit
> >
> > Differences ...
> >
> > ==== //sgl/grimoires/devel/ChangeLog#273 (text) ====
> >
> > @@ -1,3 +1,7 @@
> > +2006-03-29 Juuso Alasuutari <iuso AT sourcemage.org>
> > + * kde-core/KDE_CONFIGURE: removed dnotify query
> > + * kde-core/KDE_BUILD: added dnotify always on
> > +
> > 2006-03-28 Jose Bernardo Silva <jbernardo AT sourcemage.org>
> > * kde-apps/kradio: added, kde radio application
> >
> >
> > ==== //sgl/grimoires/devel/kde-core/KDE_BUILD#5 (xtext) ====
> >
> > @@ -1,7 +1,7 @@
> > OPTS="$KDE_DEBUG_OPTION \
> > $KDE_FINAL_OPTION \
> > - $KDE_DNOTIFY \
> > $KDE_LDFLAGS \
> > + --enable-dnotify \
> > --with-distribution \
> > --disable-dependency-tracking \
> > $OPTS" &&
> >
> > ==== //sgl/grimoires/devel/kde-core/KDE_CONFIGURE#4 (xtext) ====
> >
> > @@ -13,8 +13,5 @@
> >
> > config_query KDE_DISTCC "Enable distcc?" y &&
> >
> > -config_query_option KDE_DNOTIFY 'Use Linux directory notifications?'
> > n \
> > - '--enable-dnotify' '--disable-dnotify'
> > &&
> > -
> > config_query_option KDE_LDFLAGS 'Enable new LDFLAGS?' n
> > \
> > '--enable-new-ldflags' '--disable-new-ldflags'



--
Arwed v. Merkatz Source Mage GNU/Linux developer
http://www.sourcemage.org




Archive powered by MHonArc 2.6.24.

Top of Page