DPML Notify

[mcconnell at BerliOS <mcconnell AT mail.berlios.de>]

Author: mcconnell
Date: 2006-06-08 07:24:09 +0200 (Thu, 08 Jun 2006)
New Revision: 1511

Modified:
   
trunk/main/metro/runtime/src/main/net/dpml/metro/runtime/DefaultComponentHandler.java
Log:
housekeeping


Modified: 
trunk/main/metro/runtime/src/main/net/dpml/metro/runtime/DefaultComponentHandler.java
===================================================================
--- 
trunk/main/metro/runtime/src/main/net/dpml/metro/runtime/DefaultComponentHandler.java
       2006-06-08 05:00:12 UTC (rev 1510)
+++ 
trunk/main/metro/runtime/src/main/net/dpml/metro/runtime/DefaultComponentHandler.java
       2006-06-08 05:24:09 UTC (rev 1511)
@@ -479,15 +479,22 @@
             throw new ControllerException( error, e );
         }
         
+        // ISSUE: the current implementation is commissioning parts at the 
level 
+        // of the component when in fact we should be commissioning (and 
demommissioning
+        // parts at the level of the provider (because a component 
implementation can
+        // modify the state of a given provider which means different 
providers from the 
+        // same component may have different state.
+        
         try
         {
             if( m_model.getActivationPolicy().equals( 
ActivationPolicy.STARTUP ) )
             {
                 getLogger().debug( "activating" );
-                m_holder.getProvider();
+                Provider provider = m_holder.getProvider();
+                // provider.commission() ??? see above note
             }
             
-            m_parts.commission();
+            m_parts.commission(); // see above note
             m_active = true;
         }
         catch( RemoteException e )