FreeTDS Development Group

[Frediano Ziglio <freddy77 AT gmail.com>]

2016-05-10 23:44 GMT+01:00 Sergio NNX <sfhacker AT hotmail.com>:
>> > It appears the patch for this ("fix ct-library rows count") has broken 
>> > compute in ctlib:
>
> This project is pretty good at unit testing. Perhaps for every change 
> and/or new piece of functionality, we should add one or more unit test(s) 
> and, of course, run all the existing tests to be sure we haven't broken 
> anything.
>

test was written, but for the offending problem.
I noted that t0009 test (the only one testing compute in ct-library)
just print results not doing much tests on output so that's why I
didn't got it. I already improved it, now it's time to fix it!

> I could download the latest source code and test it locally, if that helps.
>

Didn't get the code that much, server send a mix of normal/compute
rows without any done in the middle, the patch did change mainly done
handling. If you want to try feel free. Looking at t0009 output before
and after it's quite clear that compute was broken.

Frediano