FreeTDS Development Group

["James K. Lowden" <jklowden AT freetds.org>]

On Wed, 11 Jan 2012 23:11:54 +0100
Dariusz Ostolski <dariusz.ostolski AT gmail.com> wrote:

Hello Dariusz, 

> Unfortunately I had some issues
>   when I was preparing this patch. My first mistake was downloading 
> packaged tgz
> with sources(freetds-stable which seem to be 0-91) and making all 
> changes on
> this packaged sources. To be able to easily produce a patch I've got
> an idea of checkouting
> a branch and use cvs diff, but it seems that tgz was produced from 
> different branch(or maybe a tag).

The stable-patched release tarball was quite broken, as I discovered
trying to retrace your steps.  I hope that's fixed now.  Thanks for
taking me there. 

> My cvs command was:
> 
> cvs -z3 
> -d:pserver:anonymous AT freetds.cvs.sourceforge.net:/cvsroot/freetds co
> -r branch-0.91 freetds
> 
> so the patch is the merge of some files from this branch and what was
> in the freetds-stable.tgz.

$ cat ~/releases/freetds-0.91/CVS/Tag 
TBranch-0_91

HTH.  I think you found a non-branch tag.  

Thank you for working on this.  I couldn't apply your patch, but I would
like to.  

I would have taken it verbatim if I could apply it to CVS HEAD.  If you
redo it, I would suggest doing it in a way that e.g.
the tds_read_config_info() signature doesn't change.  Instead of adding
a parameter, move the "interfaces" argument to the context, too.  

We prefer patches for CVS HEAD because that's always the way forward.
Working patches for the current release are also acceptable, but risk
regression on the next release if no one adapts it to HEAD.  

Regards, 

--jkl