FreeTDS Development Group

["Thompson, William" <bill.d.thompson AT baml.com>]

Hi,

There's a couple of bugs with dblib bcp in 0.91.

The ministry for code brevity has obviously got it's hands on the function 
_bcp_get_term_var() in the years since It was first written.
a bug has unfortunately been introduced whereby if the buffer being examined 
has the field terminator right at the beginning (position zero),  the code 
bails out.
This can be fixed by changing the following line in that function:

-        assert(bufpos > 0);
+        assert(bufpos >= 0);

Secondly, a more rigid validation for SYBEBCPI ("bcp_init must be called 
before any other bcp routines") has been introduced.
This causes me a small problem in the case of bcp_done() , which you used to 
be able to call twice in succession without a problem.
Alas now the second call fails.

The more relaxed validation actually mirrors the behaviour of Sybase 
dblibrary in this instance, and for many reasons, it's difficult to remove 
the second call to bcp_done() from my application, so I'd be grateful if the 
validation could be removed from bcp_done.

This can be achieved by the following change in that function

-         CHECK_PARAMETER(dbproc->bcpinfo, SYBEBCPI, FAIL);
+         if (!(dbproc->bcpinfo))
+                return 0;

Thanks,


Bill Thompson

GMO Technology
Bank of America Merrill Lynch
5 Canada Square
London E14 5AQ
Phone: +44 (0)207 995 8307
Email: bill.d.thompson AT baml.com


----------------------------------------------------------------------
This message w/attachments (message) is intended solely for the use of the 
intended recipient(s) and may contain information that is privileged, 
confidential or proprietary. If you are not an intended recipient, please 
notify the sender, and then please delete and destroy all copies and 
attachments, and be advised that any review or dissemination of, or the 
taking of any action in reliance on, the information contained in or attached 
to this message is prohibited. 
Unless specifically indicated, this message is not an offer to sell or a 
solicitation of any investment products or other financial product or 
service, an official confirmation of any transaction, or an official 
statement of Sender. Subject to applicable law, Sender may intercept, 
monitor, review and retain e-communications (EC) traveling through its 
networks/systems and may produce any such EC to regulators, law enforcement, 
in litigation and as required by law. 
The laws of the country of each sender/recipient may impact the handling of 
EC, and EC may be archived, supervised and produced in countries other than 
the country in which you are located. This message cannot be guaranteed to be 
secure or free of errors or viruses. 

References to "Sender" are references to any subsidiary of Bank of America 
Corporation. Securities and Insurance Products: * Are Not FDIC Insured * Are 
Not Bank Guaranteed * May Lose Value * Are Not a Bank Deposit * Are Not a 
Condition to Any Banking Service or Activity * Are Not Insured by Any Federal 
Government Agency. Attachments that are part of this EC may have additional 
important disclosures and disclaimers, which you should read. This message is 
subject to terms available at the following link: 
http://www.bankofamerica.com/emaildisclaimer. By messaging with Sender you 
consent to the foregoing.