Skip to Content.
Sympa Menu

freetds - Re: [freetds] Fw: tds_write_packet returns FAIL

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: Frediano Ziglio <freddy77 AT gmail.com>
  • To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] Fw: tds_write_packet returns FAIL
  • Date: Sat, 2 Apr 2011 15:15:53 +0200

Il giorno 02/apr/2011, alle ore 13.58, "James K. Lowden" <jklowden AT schemamania.org > ha scritto:

tds_write_packet() returns TDS_FAIL if zero bytes were written, but
it's not an error to send a zero-length query.

I think the return statement below should be

return sent < 0 ? TDS_FAIL : TDS_SUCCEED;

but maybe I'm missing something?

tds_write_packet(TDSSOCKET * tds, unsigned char final)
...
sent = tds_goodwrite(tds, tds->out_buf,
tds->out_pos, final);
...
return sent <= 0 ? TDS_FAIL : TDS_SUCCEED;


An empty query has an header so here out_pos is always > 0 and tds_goodwrite has to return a value strictly greater than 0. I don't remember if 0 is a special value from tds_goodwrite.

bye
freddy77





Archive powered by MHonArc 2.6.24.

Top of Page