FreeTDS Development Group

["Craig A. Berry" <craigberry AT mac.com>]

The attached patch completes the client charset handling changes we've  
had in progress for a couple weeks now.  It includes changes  
previously submitted but not yet applied as well some new changes.  It  
makes sense to look at it all together as one integral set of changes.

Here's what it does:

1.) Completely removes client charset handling from locales.conf  
processing, including removing the client_charset field from the  
TDSLOCALE structure.  This is obviously a binary incompatibility and  
should trigger relevant policies about when it can ship and so forth.

2.) Sets the client charset based on the current locale in  
tds_alloc_connection(), essentially moving logic to there from  
tds_alloc_locale().

3.)  In tds_iconv_info_init(), reports problems getting a canonical  
charset without using the nonexistent canonical name that it failed to  
look up.

4.)  Modifies tsql so that it does not hard-wire the client charset to  
whatever the current locale says it is.  It now lets the library  
default it to that, but it can be overridden by either freetds.conf or  
by the newly implemented -J command line option.  Of course the  
freetds.conf setting works for any application, not just tsql.

Affected files:

% lsdiff -s charset_update.patch
! include/tds.h
! src/apps/tsql.c
! src/tds/iconv.c
! src/tds/locale.c
! src/tds/mem.c

________________________________________
Craig A. Berry
mailto:craigberry AT mac.com

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser

Attachment: charset_update.patch
Description: Binary data