freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

[freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen()

From: "Craig A. Berry" <craigberry AT mac.com>
To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
Subject: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen()
Date: Fri, 20 Mar 2009 12:52:35 -0500

The CHECK_NULP statement removed by the attached patch is not actually checking anything except whether random data from the stack is non- zero. Usually it will be, but why depend on it and what good would it do to know that?

My compiler said something about "dbproc fetched but not initialized" and I'm sure gcc and other compilers have ways to generate similar warnings.
________________________________________
Craig A. Berry
mailto:craigberry AT mac.com

"... getting out of a sonnet is much more
difficult than getting in."
Brad Leithauser

Attachment: nulp.patch
Description: Binary data

[freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), Craig A. Berry, 03/20/2009
- Re: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), James K. Lowden, 03/20/2009
  - Re: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), Craig A. Berry, 03/20/2009
    - Re: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), Craig A. Berry, 03/21/2009
      - Re: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), James K. Lowden, 03/21/2009
        
        Re: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), Frediano Ziglio, 03/23/2009
        
        Re: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), Craig A. Berry, 03/23/2009
        
        Re: [freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen(), Frediano Ziglio, 03/23/2009