Skip to Content.
Sympa Menu

freetds - Re: [freetds] suspected corruption

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: "James K. Lowden" <jklowden AT freetds.org>
  • To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] suspected corruption
  • Date: Wed, 5 Dec 2007 11:39:56 -0500

ZIGLIO, Frediano, VF-IT wrote:
>
> This morning I wrote this patch... still not that much...

Um, I'm not that fond of the change to the switch. You replaced my NULL
bindval flag with two more (null_term and padding), Then you set the flags
and goto the memset operation. All so there's only one call to memset(3)?
I don't see how that's better.

There are some other parts of your patch I like, particularly not freeing
the old bindval until pval is ready.

--jkl




Archive powered by MHonArc 2.6.24.

Top of Page