FreeTDS Development Group

["Lowden, James K" <james.k.lowden AT alliancebernstein.com>]

> From: ZIGLIO, Frediano, VF-IT
> Sent: Monday, January 08, 2007 8:29 AM
> > James K. Lowden wrote:
> > 
> > net.c has been redone in terms of tds_select.  Cancel
> > messages are now subject to the same timeouts as queries.
> > tds_goodwrite looks a lot like tds_goodread.  Timeout conditions
> > invoke the client library's error handler.
> 
> Looking at tds_goodread/tds_goodwrite it seems that moving tdserror
> call in tds_select would help reducing code.

Hi Freddy, 

Problem is that tdserror passes a msgno, and tds_select doesn't know why
we're selecting.  In tds_goodwrite, we pass TDSEWRIT; in tds_goodread,
we pass TDSEREAD.  We could pass the TDSERRNO into tds_select and let it
call tdserror, but I don't think that would simplify the code very much.


We might eventually need tds_select to know why we're selecting, whether
for reading or writing (or other), because it might need to interact
with the client library differently.  If we do that, then we might want
to move the tdserror call inside tds_select.   

Thank you for your other comments.  I won't be able to respond to them
until tonight, and then I want to write a proper db-lib timeout test.
I'll think about the naming convention, too.  

Regards, 

--jkl

-----------------------------------------
The information contained in this transmission may be privileged and
confidential and is intended only for the use of the person(s) named
above. If you are not the intended recipient, or an employee or agent 
responsible
for delivering this message to the intended recipient, any review, 
dissemination,
distribution or duplication of this communication is strictly prohibited. If 
you are
not the intended recipient, please contact the sender immediately by reply 
e-mail
and destroy all copies of the original message. Please note that we do not 
accept
account orders and/or instructions by e-mail, and therefore will not be 
responsible
for carrying out such orders and/or instructions.  If you, as the intended 
recipient
of this message, the purpose of which is to inform and update our clients, 
prospects
and consultants of developments relating to our services and products, would 
not
like to receive further e-mail correspondence from the sender, please "reply" 
to the
sender indicating your wishes.  In the U.S.: 1345 Avenue of the Americas, New 
York,
NY 10105.