FreeTDS Development Group

["Lowden, James K" <james.k.lowden AT alliancebernstein.com>]

> From: Christos Zoulas
> Sent: Tuesday, November 28, 2006 9:02 AM
> 
> On Nov 28,  8:10am, Glenn AT addsys.com ("Glenn, Chris") wrote:  --
> Subject: Re: [freetds] Issue connecting to SQL Server from Linux
> Host with
> 
> | The code itself looks OK, and comparing it to revision 1.14 (Tue
> | Feb 22 16:04:36 2005), most of the changes are to the logging
> | code and adding support for DOS32.  That makes me wonder if it's
> | a matter of configure perhaps misdetecting your system somehow.
> | I think it was around that time that we upgraded the toolset that
> | generates the configure script.
> 
> The code is broken (if I am looking at the right version). All the
> fields of sockaddr_in are required to be initialized to 0. Try
> adding a:
> 
>       (void)memset(&sin, 0, sizeof(sin));
> 
> at the beginning of the function.

This is why it's good to have someone like Christos active on the list.


Try the below patch, and cross your fingers.  

--jkl

Index: src/tds/net.c
===================================================================
RCS file: /cvsroot/freetds/freetds/src/tds/net.c,v
retrieving revision 1.47
diff -u -r1.47 net.c
--- src/tds/net.c       27 Nov 2006 23:31:30 -0000      1.47
+++ src/tds/net.c       28 Nov 2006 14:50:13 -0000
@@ -171,6 +171,7 @@
 #endif
 
        FD_ZERO(&fds);
+       memset(&sin, 0, sizeof(sin));
 
        sin.sin_addr.s_addr = inet_addr(ip_addr);
        if (sin.sin_addr.s_addr == INADDR_NONE) {

-----------------------------------------
The information contained in this transmission may be privileged and
confidential and is intended only for the use of the person(s) named
above. If you are not the intended recipient, or an employee or agent 
responsible
for delivering this message to the intended recipient, any review, 
dissemination,
distribution or duplication of this communication is strictly prohibited. If 
you are
not the intended recipient, please contact the sender immediately by reply 
e-mail
and destroy all copies of the original message. Please note that we do not 
accept
account orders and/or instructions by e-mail, and therefore will not be 
responsible
for carrying out such orders and/or instructions.  If you, as the intended 
recipient
of this message, the purpose of which is to inform and update our clients, 
prospects
and consultants of developments relating to our services and products, would 
not
like to receive further e-mail correspondence from the sender, please "reply" 
to the
sender indicating your wishes.  In the U.S.: 1345 Avenue of the Americas, New 
York,
NY 10105.