FreeTDS Development Group

["Thompson, Bill D (London)" <bill_d_thompson AT ml.com>]

Freddy,

shall I have a go at sorting this out ?

Bill

-----Original Message-----
From: freetds-bounces AT lists.ibiblio.org
[mailto:freetds-bounces AT lists.ibiblio.org] On Behalf Of Thompson, Bill D
(London)
Sent: 27 January 2006 14:39
To: FreeTDS Development Group
Subject: Re: [freetds] dblib bcp, t0017 broken


Freddy,

hope you had a nice coffee.

The patch was to do with "native" format bcp files, and the
representation of NULL values therein.
Your data file for t0017.in is a kind of "native" format, so it's
falling into this code.
I don't like this code much.

Bill

-----Original Message-----
From: freetds-bounces AT lists.ibiblio.org
[mailto:freetds-bounces AT lists.ibiblio.org] On Behalf Of ZIGLIO,
Frediano, VF-IT
Sent: 27 January 2006 14:26
To: FreeTDS Development Group
Subject: Re: [freetds] dblib bcp, t0017 broken


> 
> Hi Freddy,
> 
> I don't understand code in bcp.c lines 1240 onwards.
> This is yours and james' code...
> 
> what is this byte its reading ?
> I don't understand what the program is expecting to find here...
> 
> code used to read (long time ago) ...
> 
> } else { /* unterminated field */
>     if (collen) 
>        if (fread(coldata, collen, 1, hostfile) != 1) {
>           _bcp_err_handler(dbproc, SYBEBCRE);
>           return (FAIL);
>        }
>     }
> }
> 
> Bill
> 

Yes, you are right, I think patch came from Christos

https://lists.ibiblio.org/sympa/arc/freetds/2004q1/thread.html

https://lists.ibiblio.org/sympa/arc/freetds/2004q1/015049.html
https://lists.ibiblio.org/sympa/arc/freetds/2004q1/015068.html
https://lists.ibiblio.org/sympa/arc/freetds/2004q1/015077.html
https://lists.ibiblio.org/sympa/arc/freetds/2004q1/015569.html

>From ChangeLog

Thu Mar 11 22:31:44 EST 2004    JK Lowden <jklowden AT schemamania.org>
        * doc/userguide.sgml added OS X build procedure by Dmitri
Fedortchenko
        * src/dblib/bcp.c applied patch from ML from Christos

Now... what this patch should fix? I'm trying to get a reply from
https://lists.ibiblio.org/sympa/arc/freetds/2003q4/thread.html (Cf. "bcp
is really busted" thread).

Well... I think I'll go for a coffe' :)

freddy77
_______________________________________________
FreeTDS mailing list
FreeTDS AT lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/freetds
--------------------------------------------------------

If you are not an intended recipient of this e-mail, please notify the
sender, delete it and do not read, act upon, print, disclose, copy,
retain or redistribute it. Click here for important additional terms
relating to this e-mail.     http://www.ml.com/email_terms/
--------------------------------------------------------
_______________________________________________
FreeTDS mailing list
FreeTDS AT lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/freetds