FreeTDS Development Group

["Lowden, James K" <LowdenJK AT bernstein.com>]

> From: Frediano Ziglio
> Sent: Thursday, September 22, 2005 9:18 AM
> 
> dbperror (DBPROCESS *dbproc, DBINT msgno, int errnum)
> {
>         static int microsoft_timeouts = 0;
> ...
>         switch (rc) {         case INT_CONTINUE:
>                 /* Microsoft does not define INT_TIMEOUT.  Instead,
> two consecutive INT_CONTINUEs yield INT_CANCEL. */
>                 if (dbproc && dbproc->msdblib && ++microsoft_timeouts
> >=2) {
>                         microsoft_timeouts = 0;
> rc = INT_CANCEL;
>                 }       /* fall through */
>         case INT_CANCEL:
>         case INT_TIMEOUT:
> ...
> 
> In this case static means:
> - not reentrant
> - possible strange behavior for multiple connection
> 
> I would move microsoft_timeouts in dbproc

Well said.  If you get to it first, I suggest the field be
dbproc->ntimeouts.  

--jkl

-----------------------------------------
The information contained in this transmission may be privileged and
confidential and is intended only for the use of the person(s) named
above. If you are not the intended recipient, or an employee or agent 
responsible
for delivering this message to the intended recipient, any review, 
dissemination,
distribution or duplication of this communication is strictly prohibited. If 
you are
not the intended recipient, please contact the sender immediately by reply 
e-mail
and destroy all copies of the original message. Please note that we do not 
accept
account orders and/or instructions by e-mail, and therefore will not be 
responsible
for carrying out such orders and/or instructions.  If you, as the intended 
recipient
of this message, the purpose of which is to inform and update our clients, 
prospects
and consultants of developments relating to our services and products, would 
not
like to receive further e-mail correspondence from the sender, please "reply" 
to the
sender indicating your wishes.  In the U.S.: 1345 Avenue of the Americas, New 
York,
NY 10105.