FreeTDS Development Group

["Lowden, James K" <LowdenJK AT bernstein.com>]

> From: ZIGLIO, Frediano, VF-IT
> Sent: Friday, July 01, 2005 10:09 AM
> 
> static int rtrim(char *istr, int ilen) {
>         char *t; int olen = ilen;
> 
>         for (t = istr + (ilen - 1); *t == ' '; t--) {
>                 *t = '\0'; olen--;
>         } return olen;
> }
> 
> this contain a buffer underflow...
> 
> Perhaps it would better to rewrite like
> 
> static int rtrim(char *istr, int ilen) {
>         char *t;
> 
>         for (t = istr + ilen; --t > istr && *t == ' '; ) {
>                 *t = '\0'; --ilen;
>         } return ilen;
> }
> 
> (it solve also '' problem)

I like this better:

static int
rtrim(char *str, int len)
{
        char *t;

        for (t = str + --len; t > str && *t == ' '; t--) {
                *t = '\0';
        }
        return t - str;
}

Thanks for the patch Bill.  We distinguish, don't we, between char and
varchar?  char columns shouldn't be trimmed.  At least, Microsoft's bcp
doesn't trim them.  

--jkl




-----------------------------------------
The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s) 
named
above. If you are not the intended recipient, or an employee or agent 
responsible
for delivering this message to the intended recipient, any review, 
dissemination,
distribution or duplication of this communication is strictly prohibited. If 
you are
not the intended recipient, please contact the sender immediately by reply 
e-mail
and destroy all copies of the original message. Please note that we do not 
accept
account orders and/or instructions by e-mail, and therefore will not be 
responsible
for carrying out such orders and/or instructions.  If you, as the intended 
recipient
of this message, the purpose of which is to inform and update our clients, 
prospects
and consultants of developments relating to our services and products, would 
not
like to receive further e-mail correspondence from the sender, please "reply" 
to the
sender indicating your wishes.  In the U.S.: 1345 Avenue of the Americas, New 
York,
NY 10105.