FreeTDS Development Group

["Thompson, Bill D (London)" <bill_d_thompson AT ml.com>]

Thanks for the patch craig,

Your fixes to freebcp make sense in terms of the changes recently made
to the db-library results processing.
I would recommend their application before releasing 0.63

Bill

-----Original Message-----
From: freetds-bounces AT lists.ibiblio.org
[mailto:freetds-bounces AT lists.ibiblio.org] On Behalf Of Craig A. Berry
Sent: 15 January 2005 23:33
To: FreeTDS Development Group
Subject: [PATCH] VMS build update and freebcp nit (was Re: [freetds]
0.63Release Candidate 9)


I apologize for the lateness of this. In the attached patch, there are a
couple of minor VMS-specific changes, and a small change to freebcp,
without which I don't think it will work at all on any platform. Here
are the three changes:

-- Improve non-tty handling in vms/getpass.c
-- Workaround for MMS build utility confusing foo/bar.c with
foo/baz/bar.c
-- src/apps/freebcp.c tried to get column count after the structure that
holds it has already been freed and reinitialized.

The VMS-specific changes could wait for 0.64 if I'm the only one holding
up the release. On the other hand, they pose no risk to other platforms
and they test out ok on VMS.

I think the freebcp issue renders it unuseable, at least with TDS 7.0,
which is what I was testing with. Each call to dbresults() wipes out the
tds-level data, so you have to get the contents of
tds->res_info->num_cols into the dblib structures immediately after the
relevant dbresults() call, not two or three calls later as was happening
before my patch. 
--------------------------------------------------------
 
If you are not an intended recipient of this e-mail, please notify the 
sender, delete it and do not read, act upon, print, disclose, copy, retain or 
redistribute it. Click here for important additional terms relating to this 
e-mail.     http://www.ml.com/email_terms/ 
--------------------------------------------------------