FreeTDS Development Group

["Thompson, Bill D (London)" <bill_d_thompson AT ml.com>]

Adrian,

Thanks for raising the bug report, and the patch.

This is a legitimate bug. 
AFAICT it pertains to 0.63RC5 and current CVS, and was also present in
0.62.

Unfortunately, the patch doesn't cater for all the possibilities.
dbsqlok() *has* to read the DONE token in order to determine whether the
submitted command succeeded or failed, and report back accordingly. 

I will create a patch based on 0.63RC5, which *might* be with you before
Xmas!

Bill

-----Original Message-----
From: freetds-bounces AT lists.ibiblio.org
[mailto:freetds-bounces AT lists.ibiblio.org] On Behalf Of SourceForge.net
Sent: 20 December 2004 21:21
To: noreply AT sourceforge.net
Subject: [freetds] [ freetds-Patches-1088672 ] dbsqlok eats too many
endtokens


Patches item #1088672, was opened at 2004-12-20 15:20
Message generated for change (Tracker Item Submitted) made by Item
Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=407808&aid=1088672&gro
up_id=33106

Category: db-lib
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Adrian Daley (agd)
Assigned to: Nobody/Anonymous (nobody)
Summary: dbsqlok eats too many end tokens

Initial Comment:
It appears that dbsqlok can eat the end token
for an empty result set so that the next dbresults
call will skip over it.  This may be similar to patch
744992 but the code has changed to need a different
patch.

The attached file shows tdsdump output before and
after the patch is applied.  The patch changes
dbsqlok to return SUCCEED for end tokens and let
dbresults process the information.  From what I
saw this affected end tokens at the beginning of
a packet.  With the patch applied all of the dblib
unit tests continue to pass including the test 18
that the patch updates to show the problem.

Please look over this change.  While the test cases
work fine and our application has used the change
for the last week I don't know if this overlooks
certain TDS situations.

Thank you,
Adrian Daley



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=407808&aid=1088672&gro
up_id=33106
_______________________________________________
FreeTDS mailing list
FreeTDS AT lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/freetds 
--------------------------------------------------------
 
If you are not an intended recipient of this e-mail, please notify the 
sender, delete it and do not read, act upon, print, disclose, copy, retain or 
redistribute it. Click here for important additional terms relating to this 
e-mail.     http://www.ml.com/email_terms/ 
--------------------------------------------------------