FreeTDS Development Group

["Lowden, James K" <LowdenJK AT bernstein.com>]

> From: Hi-Ho [mailto:jbaba AT amy.hi-ho.ne.jp]
> Sent: July 1, 2003 12:10 AM
> 
> (1) "server charset" is not necessarily "singlebyte".
> (2) "server charset" and "client charset" are not necessarily same.
> 
> e.g.
>    Client charset = EUC-JP
>    Server charset = CP932
>    Of course, UCS2 is used with TDS7.0/8.0.
> 
> I present some patches.(base of freetds-0.62.dev.20030630)

Jiro, 

I looked over your patch.  It basically makes FreeTDS DTRT if the server's
"singlebyte" character set differs from the client's.  It looks great,
thanks.  

The name "client2server_singlebyte" (mine) is clearly wrong.  Thank you for
pointing that out.  I think perhaps "client2server_chardata" is better, and
parallels "client2server_metadata".  

The "IS_TDSENVCHARSET" (yours) is probably unnecessary, or will be.
tds_iconv() should recognize a -1 conversion descriptor, and do a memcpy().
That avoids testing the descriptor for every call.  

It's much better, btw, to post patches to Source Forge, where they won't get
lost.  If you do send patches to the list, please attach them rather than
making them part of the message.  Message bodies get massaged by the email
system (tabs stripped, lines wrapped) and the probability that a patch will
arrive correctly formatted is almost zero.  

I will try to integrate your work tonight.  I hope FreeTDS continues to be
useful to you, and I hope you'll be involved as we proceed with our I18N
work.  

Regards, 

--jkl
-----------------------------------------
The information contained in this transmission may contain privileged and 
confidential information and is intended only for the use of the person(s) 
named above. If you are not the intended recipient, or an employee or agent 
responsible for delivering this message to the intended recipient, any 
review, dissemination, distribution or duplication of this communication is 
strictly prohibited. If you are not the intended recipient, please contact 
the sender immediately by reply e-mail and destroy all copies of the original 
message. Please note that we do not accept account orders and/or instructions 
by e-mail, and therefore will not be responsible for carrying out such orders 
and/or instructions.