FreeTDS Development Group

["Lowden, James K" <LowdenJK AT bernstein.com>]

> From: Thompson, Bill D (London) [mailto:ThompBil AT exchange.uk.ml.com]
> Sent: March 19, 2003 9:42 AM
> 
> I have submitted patch number 706303 to sourceforge

Thanks, Bill.  

> This patch was built on last nights snapshot.

And went in very smoothly. :-)

> 1) small fix to correctly handle/return the "rows affected" count. I
> discovered that sqsh was reporting "rows affected" when it shouldn't -
> specifically if "set nocount on" had been specified.

There's something I don't understand about your change:

@@ -2063,15 +2063,10 @@
 DBINT
 dbcount(DBPROCESS * dbproc)
 {
-TDSRESULTINFO *resinfo;
 TDSSOCKET *tds;

        tds = (TDSSOCKET *) dbproc->tds_socket;
-       resinfo = tds->res_info;
-       if (resinfo)
-               return resinfo->row_count;
-       else
-               return tds->rows_affected;
+       return tds->rows_affected;
 }

and similar in ct.c.  Is row_count now superfluous?  dbcount() should return
the count of rows returned on a select statement.  I can't see that you're
stuffing that value into rows_affected instead.  

I've reviewed the patch and applied it, but I'd like to hold off the commit
until I hear from you on this.  Sorry to catch you at the end of the day.  

Regards, 

--jkl


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that we do not accept account orders and/or
instructions by e-mail, and therefore will not be responsible for carrying
out such orders and/or instructions.