FreeTDS Development Group

["Thompson, Bill D (London)" <ThompBil AT exchange.uk.ml.com>]

James, all,

I've tested release candidate 5

O/S :           Sun Solaris 2.6
Compiler:       Sun Workshop C compiler version 4.2
Database:        SQL Server 2000 & Sybase 11.9.2

All tds/unittests passed
All dblib/unittests passed
All ctlib/unittests passed

freebcp out passed
freebcp in   passed

sqsh 1.7 (ct-library)  works 
sqsh 1.4 (db-library) works

However, I've found one small bug, which manifests itself when more than 1
compute column is specified in a compute clause, e.g.

select col1 , col2, col3 from table
order by col3
compute sum(col1), sum(col2) by col3

In this case we get a segmentation fault.

This is down to a change in version 1.40 of mem.c ( some much needed memory
allocation enhancements / checks )

here's my patch to fix the problem.

static TDSCOMPUTEINFO *
tds_alloc_compute_result(int num_cols, int by_cols)
{
int col;
TDSCOMPUTEINFO *info;
int null_sz;

    TEST_MALLOC(info, TDSCOMPUTEINFO);
    memset(info,'\0',sizeof(TDSCOMPUTEINFO));

    TEST_MALLOCN(info->columns, TDSCOLINFO*, num_cols);
-    memset(info,'\0',sizeof(TDSCOLINFO*) * num_cols);
+   memset(info->columns,'\0',sizeof(TDSCOLINFO*) * num_cols);

    tdsdump_log(TDS_DBG_INFO1, "%L alloc_compute_result. point 1\n");
    info->num_cols = num_cols;
    for (col = 0; col < num_cols; col++)  {
        TEST_MALLOC(info->columns[col], TDSCOLINFO);
        memset(info->columns[col],'\0',sizeof(TDSCOLINFO));
    } 

Hope this doesn't scupper plans for a timely release of 0.61....

Bill


> -----Original Message-----
> From: Frediano Ziglio [SMTP:freddyz77 AT tin.it]
> Sent: 27 February 2003 06:54
> To:   FreeTDS Development Group
> Subject:      Re: [freetds] version 0.61, rc5
> 
> Il gio, 2003-02-27 alle 07:48, James K. Lowden ha scritto:
> > On Wed, 26 Feb 2003 01:34:24 -0500, "James K. Lowden"
> > <jklowden AT schemamania.org> wrote:
> > 
> > > Based on yesterday's discussion, release candidate 5 was published a
> few
> > > hours ago on ibiblio.org, per usual.  
> > 
> > There were no problems reported with rc5.  It will become 0.61 final
> > unless someone encounters a problem soon.  I'll count to 3.  :)
> > 
> > One.  
> > 
> 
> 4!
> I'd wait till tomorrow (you know, timezone...)
> 
> freddy77
> 
> 
> _______________________________________________
> FreeTDS mailing list
> FreeTDS AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/freetds