FreeTDS Development Group

["Lowden, James K" <LowdenJK AT bernstein.com>]

> From: ZIGLIO Frediano [mailto:Frediano.Ziglio AT vodafoneomnitel.it]
> Sent: November 12, 2002 11:13 AM
> 
> > When I do a 'make check' part way through installing FreeTDS, 
> > I get the
> > following error messages...
> > 
> > ---- BEGIN ----
> > t0001.c: Testing login, logout
> > tds_connect() failed
> > try_tds_login() failed
> > FAIL: t0001

Two observations on unit tests.

1.  The source file names are dumb:  

        t0001.c: Testing login, logout
should say
        loginout.c: Testing login, logout

2.  The messages don't reflect the test data:

        tds_connect() failed
        try_tds_login() failed
should say
        Connecting to server S port P host H address IP database D user U
password P
        tds_connect() failed, line __LINE__
        try_tds_login() failed, line __LINE__

That is, tests should recapitulate their inputs.  

I suggest that new tests at least be more descriptive and verbose.  I
mention it only because we're putting some effort into the tests wrt
factoring and other goodness, and it might be easier to make such
adjustments at the same time.  Clearer feedback would help newcomers
especially, IMO.  

Thanks for listening.  

--jkl


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that we do not accept account orders and/or
instructions by e-mail, and therefore will not be responsible for carrying
out such orders and/or instructions.