freetds AT lists.ibiblio.org
Subject: FreeTDS Development Group
List archive
- From: Brian Bruns <camber AT ais.org>
- To: TDS Development Group <freetds AT franklin.metalab.unc.edu>
- Subject: Re: bug in login.c (latest version)
- Date: Tue, 3 Sep 2002 08:19:58 -0400 (EDT)
Spoke too quickly, I see that domains are keyed off HAVE_SSL now.
DOMAIN should go. we should simply check HAVE_SSL (when setting
domain_login only) as there is no difference between the two.
Brian
On Tue, 3 Sep 2002, Bill Thompson wrote:
> there's a bug in the latest version of login.c , in tds7_send_login()
>
> we seem to have left in reference to the variable domain_login instead of
> using the #if DOMAIN precompiler directive. As the value of domain_login
> has been reversed, this has an adverse effect.
>
> Itwasnteasytoseeastherewerenoblanklinestobreakupthecodeintoreadablechunks;-)
>
>
>
> I have replaced the lines:
>
> tds7_ascii2unicode(tds,config->host_name, unicode_string, 255);
> tds_put_n(tds,unicode_string,host_name_len * 2);
> if (!domain_login) {
> tds7_ascii2unicode(tds,config->user_name, unicode_string, 255);
> tds_put_n(tds,unicode_string,user_name_len * 2);
> tds7_ascii2unicode(tds,config->password, unicode_string, 255);
> tds7_crypt_pass(unicode_string, password_len * 2, unicode_string);
> tds_put_n(tds,unicode_string,password_len * 2);
> }
> tds7_ascii2unicode(tds,config->app_name, unicode_string, 255);
>
> with:
>
> tds7_ascii2unicode(tds,config->host_name, unicode_string, 255);
> tds_put_n(tds,unicode_string,host_name_len * 2);
>
> #if DOMAIN
> /* Do Nothing */
> #else
> tds7_ascii2unicode(tds,config->user_name, unicode_string, 255);
> tds_put_n(tds,unicode_string,user_name_len * 2);
> tds7_ascii2unicode(tds,config->password, unicode_string, 255);
> tds7_crypt_pass(unicode_string, password_len * 2, unicode_string);
> tds_put_n(tds,unicode_string,password_len * 2);
> #endif
>
> tds7_ascii2unicode(tds,config->app_name, unicode_string, 255);
>
> And it did the business for me.
>
> Bill
>
> ---
> You are currently subscribed to freetds as: [camber AT ais.org]
> To unsubscribe, forward this message to $subst('Email.Unsub')
>
>
-
Re: bug in login.c (latest version),
Bill Thompson, 09/03/2002
- <Possible follow-up(s)>
- Re: bug in login.c (latest version), ZIGLIO Frediano, 09/03/2002
- Re: bug in login.c (latest version), Bill Thompson, 09/03/2002
- Re: bug in login.c (latest version), Brian Bruns, 09/03/2002
- Re: bug in login.c (latest version), ZIGLIO Frediano, 09/03/2002
- Re: bug in login.c (latest version), Brian Bruns, 09/03/2002
- Re: bug in login.c (latest version), Thompson, Bill D (London), 09/03/2002
- Re: bug in login.c (latest version), Brian Bruns, 09/03/2002
- Re: bug in login.c (latest version), Thompson, Bill D (London), 09/03/2002
- Re: bug in login.c (latest version), ZIGLIO Frediano, 09/03/2002
- Re: bug in login.c (latest version), ZIGLIO Frediano, 09/03/2002
- Re: bug in login.c (latest version), James K. Lowden, 09/03/2002
- Re: bug in login.c (latest version), James K . Lowden, 09/03/2002
- Re: bug in login.c (latest version), Brian Bruns, 09/03/2002
Archive powered by MHonArc 2.6.24.