FreeTDS Development Group

[Brian Bruns <camber AT ais.org>]

Jim,

I think the operative question is how often do we expect this to change?
I mean, conversions fall into one of three categories

1) it converts (almost anything to string, lots of stuff)

2) it will never convert (datetime to money)

3) it should convert but we haven't implemented yet (money to float, lots 
of stuff)

At some point in the future (uh yeah...hell freezes over, actually there 
is Hell, Michigan which is but a few miles from me that does freeze over 
on occasion) we will support all possible conversions at which point there 
is no sense in generating the file.  I'd think it's safe to check it in, 
it's not like configure or Makefile that changes all the damn time.

Just my two cents.

Brian

On Thu, 11 Jul 2002, James K. Lowden wrote:

> On Thu, 11 Jul 2002 15:47:15 -0400, "freddy77"
> <Frediano.Ziglio AT vodafoneomnitel.it> wrote:
> 
> > > I decided to leave cvs a little broken, rather than
> > > adding a file that might not belong there.  
> > > 
> > Perhaps a patch like this is useful:
> > 
> > Index: src/tds/.cvsignore
> > ===================================================================
> > RCS file: /cvsroot/freetds/freetds/src/tds/.cvsignore,v
> > retrieving revision 1.3
> > diff -u -r1.3 .cvsignore
> > --- src/tds/.cvsignore      21 Nov 2001 04:31:03 -0000      1.3
> > +++ src/tds/.cvsignore      11 Jul 2002 19:42:42 -0000
> > @@ -4,3 +4,4 @@
> >  *.lo
> >  *.la
> >  .deps
> > +tds_willconvert.h
> 
> Frediano, 
> 
> Thanks!  That's similar to what I had in mind.  I don't have time to check
> this tonight (sorry, I'd like to).  One question, though:  
> 
> It looks to me like this will create a tds_willconvert.h target in the
> Makefile.  I don't want to do that, because that would mean you couldn't
> build FreeTDS without Perl.  Instead, I want to generate tds_willconvert.h
> when "configure" is generated by autoconf.  I think that means I have to
> modify "configure.in".  Do you know how to do that?  
> 
> Either that, or give up and put it in CVS.  
> 
> Regards, 
> 
> --jkl
> 
> 
> > Index: src/tds/Makefile.am
> > ===================================================================
> > RCS file: /cvsroot/freetds/freetds/src/tds/Makefile.am,v
> > retrieving revision 1.6
> > diff -u -r1.6 Makefile.am
> > --- src/tds/Makefile.am     5 Jul 2002 20:23:49 -0000       1.6
> > +++ src/tds/Makefile.am     11 Jul 2002 19:42:42 -0000
> > @@ -1,7 +1,15 @@
> >  SUBDIRS                    =       unittests
> >  
> >  lib_LTLIBRARIES            =       libtds.la
> > -libtds_la_SOURCES  =       mem.c token.c util.c login.c read.c write.c 
> > convert.c
> > numeric.c config.c query.c iconv.c locale.c challenge.c threadsafe.c
> > +libtds_la_SOURCES  =       mem.c token.c util.c login.c read.c write.c \
> > +   convert.c numeric.c config.c query.c iconv.c locale.c challenge.c
> > \+  threadsafe.c tds_willconvert.h
> >  INCLUDES           =       -I$(top_srcdir)/include
> >  LIBS               = @LIBICONV@
> >  libtds_la_LIBADD   = $(NETWORK_LIBS)
> > +
> > +convert.o: tds_willconvert.h
> > +convert.lo: tds_willconvert.h
> > +
> > +tds_willconvert.h: convert.c
> > +   perl -x $< > $@
> > 
> > freddy77
>