freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Re: [PATCH] msg_number to TDS_UINT

From: Steve Langasek <vorlon AT netexpress.net>
To: TDS Development Group <freetds AT franklin.oit.unc.edu>
Subject: Re: [PATCH] msg_number to TDS_UINT
Date: Sat, 26 Jan 2002 12:54:23 -0600

On Sat, Jan 26, 2002 at 01:49:49PM -0500, Bob Kline wrote:
> On Sat, 26 Jan 2002, Steve Langasek wrote:

> > My concern is that this is being done specifically *because* of the
> > line in dblib/dbutil.c:

> > if( tds->msg_info->msg_number > 0 )

> > If you change msg_number to be a uint, then this comparison will
> > always be false.

> Zero is a legitimate value for an unsigned integer.

Ah, of course. Is this the intended meaning of the comparison, then, to
check if msg_number != 0?

Steve Langasek
postmodern programmer

Attachment: pgpZBtdEGeaSe.pgp
Description: PGP signature

[PATCH] msg_number to TDS_UINT, Dave Brotherstone, 01/26/2002
- <Possible follow-up(s)>
- Re: [PATCH] msg_number to TDS_UINT, Steve Langasek, 01/26/2002
- Re: [PATCH] msg_number to TDS_UINT, Chris Eleveld, 01/26/2002
- Re: [PATCH] msg_number to TDS_UINT, Bob Kline, 01/26/2002
- Re: [PATCH] msg_number to TDS_UINT, Steve Langasek, 01/26/2002
- Re: [PATCH] msg_number to TDS_UINT, Dave Brotherstone, 01/26/2002