Developer discussion for Creative Commons technology and tools

["SourceForge.net" <noreply AT sourceforge.net>]

Patches item #2771992, was opened at 2009-04-17 22:24
Message generated for change (Settings changed) made by jhorigan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=559968&aid=2771992&group_id=80503

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: John Horigan (jhorigan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Have LicenseChooser.js support being embedded inside a form

Initial Comment:
LicenseChooser.js does not work properly in many browsers (Safari, Firefox, 
Opera) if the script tag that includes it is placed inside an html form. The 
problem seems to be that the script includes an html fragment that contains a 
form element (with id cc_js_cc_js_result_storage). Internet Explorer seems to 
be able to handle a form within a form, but other browsers fail in some 
manner.

In this patch the javascript that includes the html fragment searches up the 
DOM element tree to see if the script tag is contained within a form or not. 
If the script tag is within a form then the cc_js_cc_js_result_storage 
element is converted from a <form> element to a <p> element before the html 
is added to the DOM. If the script tag is not within a form then the existing 
template.html is used.

----------------------------------------------------------------------

>Comment By: John Horigan (jhorigan)
Date: 2009-05-01 00:06

Message:
This patch has been accepted for the next version after 0.96.

----------------------------------------------------------------------

Comment By: John Horigan (jhorigan)
Date: 2009-04-20 21:37

Message:
I forgot to mention that the patch also changes the outmost contain element
from a <span> to a <div>. I made this change because the W3C HTML Validator
complained that block-level elements are not allowed inside of inline
elements. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=559968&aid=2771992&group_id=80503