[SM-Grimoire-Bugs] [Bug 10940] get_kernel_version isn't flexible enough

bugzilla-daemon at bugs.sourcemage.org bugzilla-daemon at bugs.sourcemage.org
Tue Oct 17 11:27:36 EDT 2006


------- Additional Comments From dmlb2000 at gmail.com  2006-10-17 10:27 -------
I'd like to mention a few things when checking files in the source tree for
version information:

1) they move

You can't count on a version string from a grep in a file in the linux source
tree to come up with the result you want for every version of the kernel.  For
example include/linux/version.h used to have the UTSRELEASE variable contained
in it, but with the current kernel (2.6.18) it doesn't contain that string
define anymore.  So what you did by grepping the CONFIG file for the version
doesn't work completely, adding a file in the base of the linux source tree
called localversion-blah then adding '-blah' to the first line in the file
breaks the config grep implemented in test.

I would suggest doing it the way dkowis suggested:
1) check for a user controlled var
2) check for sorcery version (something we know will work)
3) check for linux source file in some generic way that it should work 80% of
the time

just my thoughts

Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the SM-Grimoire-Bugs mailing list