[SM-Grimoire-Bugs] [Bug 10173] New: /sbin/ifup calls a bogus ifconfig command if some options are unset

bugzilla-daemon at bugs.sourcemage.org bugzilla-daemon at bugs.sourcemage.org
Sat Dec 3 13:40:01 EST 2005


http://bugs.sourcemage.org/show_bug.cgi?id=10173

           Summary: /sbin/ifup calls a bogus ifconfig command if some
                    options are unset
           Product: Codex
           Version: test grimoire
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P4
         Component: net
        AssignedTo: sqweek at gmail.com
        ReportedBy: sqweek at gmail.com
                CC: sm-grimoire-bugs at lists.ibiblio.org


/sbin/ifup contains the line:

   ifconfig $DEV $IP broadcast $BROADCAST netmask $NETMASK $ARGS

 This results in an erroneous command line if the user happens to skip setting
BROADCAST or NETMASK in netconf (which I, personally, would /never/ do >.>).
 I have a patch which appends $BROADCAST and $NETMASK to $ARGS if they're
non-empty as is currently done with $POINTOPOINT and $MTU, as well as making the
$ARGS building code a bit more pretty :)
 BUT, maybe a better fix is to ensure these settings are set in netconf...

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.



More information about the SM-Grimoire-Bugs mailing list