[freetds] [PATCH] Two VMS configuration nits

Craig A. Berry craigberry at mac.com
Sun Jun 14 15:23:20 EDT 2015


> On Jun 14, 2015, at 11:53 AM, Frediano Ziglio <freddy77 at gmail.com> wrote:
> 
> Il 12/Giu/2015 19:48, "Craig A. Berry" <craigberry at mac.com> ha scritto:
>> 
>> There are two attached patches.  One avoids a redefinition of a symbol in
> the VMS-specific Makefile equivalent which bothers one VMS make utility
> (MMS) but not another (MMK).  The other enables the replacement socketpair
> for older VMS systems that don’t have their own.  These are against master
> but should be quite safe for the 0.95 branch as well.
>> 
>> Thanks to Norm Lastovica for problem reports and testing.
>> 
> 
> Looks good. Did you try to force socket pair replacement to be used. In
> Linux it worked but to remove a warning I had to add unistd.h include. Do
> you want me to add to 0.95 too? Should you/me add a comment in changeset
> comment about Norm?
> 

I believe there was a warning about close() not being declared, so yes, unistd.h should take care of that.  But it did work despite the warning.  And yes, they should be applied to 0.95 as well as master.  Good call on crediting Norm.  I’ve attached a revised version of patch #0002 with that added to the commit message.

________________________________________
Craig A. Berry
mailto:craigberry at mac.com

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-replacement-socketpair-on-pre-8.2-VMS-systems.patch
Type: application/octet-stream
Size: 4099 bytes
Desc: not available
URL: <http://lists.ibiblio.org/pipermail/freetds/attachments/20150614/285196c6/attachment.obj>


More information about the FreeTDS mailing list