[freetds] incorrect fix in net.c

Frediano Ziglio freddy77 at gmail.com
Sun Apr 5 09:48:48 EDT 2009


2009/4/4 James K. Lowden <jklowden at schemamania.org>:
> --- src/tds/net.c       16 Mar 2009 07:49:57 -0000      1.90
> +++ src/tds/net.c       27 Mar 2009 09:22:49 -0000      1.91
> @@ -700,7 +700,7 @@
>           continue;
>   }
>
> -  if (0 == nput || nput < 0 && sock_errno == EAGAIN)
> +  if (0 == nput || sock_errno == EAGAIN)
>           continue;
>
>
> The above change is incorrect.  sock_errno has no meaning unless
> send/write returns -1.
>

> 0 case is already handled, 0 case is tested by "0 == nput" so only < 0 is left (where sock_errno is valid)

freddy77



More information about the FreeTDS mailing list