[freetds] SQLGetData (bug in ODBC driver)

ZIGLIO, Frediano, VF-IT Frediano.Ziglio at vodafone.com
Mon Jul 7 03:51:16 EDT 2008


> Suren A. Chilingaryan wrote:
> > 
> > I have reworked a little bit my patch and have implemented 
> unit tests. 
> > Actually, in the old patch I have missed the comparison checking if 
> > there is still data available. This comparison was again checking 
> > processed number of bytes in output buffer against size of 
> source. And 
> > BINARY to CHAR conversion (which I said I haven't checked) 
> was actually 
> > wrong and even not needed.
> > 
> > Additionally, I have implemented the CHAR to BINARY conversion for 
> > SQLPutData. The unit test is checking both SQLGetData and 
> SQLPutData 
> > functionality.
> 
> Hi Suren, 
> 
> Nice work.  Thanks for the patch!  I worked on it some myself 
> to add the
> ODBC error messages and some other tidying up.  Hope you like 
> the result. 
> 
> 
> I applied it to CVS HEAD.  I thought it's better if Frediano 
> takes a look
> at it before applying it to 0.82.  
> 

I seems the patch is not fully applied, prepare_query.c and unittest was not patched.
Just an omission or did you decide to exclude part of the patch??

Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3129 bytes
Desc: not available
Url : http://lists.ibiblio.org/pipermail/freetds/attachments/20080707/ff26b74d/attachment.bin 


More information about the FreeTDS mailing list