Skip to Content.
Sympa Menu

sm-discuss - Re: [SM-Discuss] [SM-Commit] GIT changes to master sorcery by Jaka Kranjc (b04e448cba60b964e57245a512770e6d5f0a42bb)

sm-discuss AT lists.ibiblio.org

Subject: Public SourceMage Discussion List

List archive

Chronological Thread  
  • From: "Remko van der Vossen" <wich AT stack.nl>
  • To: sm-discuss AT lists.ibiblio.org
  • Subject: Re: [SM-Discuss] [SM-Commit] GIT changes to master sorcery by Jaka Kranjc (b04e448cba60b964e57245a512770e6d5f0a42bb)
  • Date: Wed, 25 Feb 2009 14:33:14 +0100 (CET)

> GIT changes to master sorcery by Jaka Kranjc
> commit b04e448cba60b964e57245a512770e6d5f0a42bb
>
> libdispel: fixed two debug statements, added two new and made pre_
> and post_remove numb again
>
> @@ -284,20 +284,22 @@ function load_spell() {
> ## Run the PRE_REMOVE script if it exists
> #-----
> function pre_remove() {
> + debug "libdispel" "pre_remove()"
> if [[ $SCRIPT_DIRECTORY ]] ; then
> run_spell_file PRE_REMOVE pre_remove
> fi
> - return $?
> + return 0
> }
>
> #-----
> ## Run the POST_REMOVE script if it exists.
> #-----
> function post_remove() {
> + debug "libdispel" "post_remove()"
> if [[ $SCRIPT_DIRECTORY ]] ; then
> run_spell_file POST_REMOVE post_remove
> fi
> - return $?
> + return 0
> }
>
> #---------------------------------------------------------------------

Why revert completely back to the old behaviour? I think it's good that we
try to be more strict in this kind of handling, we just shouldn't change
it indiscriminately, because we know stuff will break. How about changing
it just so that it gives a big fat warning if the return value is non
zero, leave it like that for a while (i.e. up to and including the next
test release, or perhaps even stable) so that spells bugs will be
discovered and can be resolved. Then change it to enforce it with the
return $? once the warning has been in test sorcery or even stable for a
while.

Remko van der Vossen.




Archive powered by MHonArc 2.6.24.

Top of Page