Skip to Content.
Sympa Menu

sm-discuss - Re: [SM-Discuss] PERFORCE change 68470 by David Michael Leo Brown Jr. for review

sm-discuss AT lists.ibiblio.org

Subject: Public SourceMage Discussion List

List archive

Chronological Thread  
  • From: Andrew <afrayedknot AT thefrayedknot.armory.com>
  • To: sm-discuss AT lists.ibiblio.org
  • Subject: Re: [SM-Discuss] PERFORCE change 68470 by David Michael Leo Brown Jr. for review
  • Date: Mon, 24 Oct 2005 21:41:59 -0700

Im going to forward this to the ML.

On Mon, Oct 24, 2005 at 11:28:26PM -0500, Jeremy Blosser wrote:
> On Oct 24, Perforce Review Daemon [p4review AT smee.org] wrote:
> > Change 68470 by david_brown@dmlb2000-dmlb2004 on 2005/10/24 23:48:56
> >
> > added gpg level to linux spell, I think it's the UPSTREAM_KEY level
> > but I'm not sure...
>
> Unfortunately no, not unless we've actually done that verification. It
> would be nice if we had a level for "the posted upstream key hasn't changed
> for 4 years", but we don't. If we did add that we'd need to let the user
> specify where it sat relative to other levels, because that would be a
> significant question. As andrew noted in IRC, it may make more sense to
> make the levels checkboxes instead of a radio button if we go that route...

Now is probably the best time to decide this so we can avoid complications.
Originally strings with relative values was the idea, so then if there
was a level in-between two other levels we could just add it and adjust
all the numbers internally. What we didnt consider was the attribute
not fitting into a nice linear scale.

We could probably just have sorcery's verification level variable be a
list of acceptable values, similar to the hash-list (checkboxes). Then
we dont have to worry about trying to order things based on our ideas.
More freedom for the user.

-Andrew


>
> > Affected files ...
> >
> > ... //sgl/grimoires/devel/kernels/linux/HISTORY#134 edit
> > ... //sgl/grimoires/devel/kernels/linux/PREPARE#18 edit
> >
> > Differences ...
> >
> > ==== //sgl/grimoires/devel/kernels/linux/HISTORY#134 (text) ====
> >
> > @@ -1,4 +1,7 @@
> > 2005-10-24 David Brown <dmlb2000 AT gmail.com>
> > + * PREPARE: added gpg level
> > +
> > +2005-10-24 David Brown <dmlb2000 AT gmail.com>
> > * latest.defaults: updated latest to 2.6.14-rc5-mm1
> > * info/patches/mm_patches/2.6.14-rc5-mm1: added
> >
> >
> > ==== //sgl/grimoires/devel/kernels/linux/PREPARE#18 (xtext) ====
> >
> > @@ -865,7 +865,7 @@
> > echo "SOURCE=\$source"
> > echo "SOURCE_URL=\$source_url"
> > echo "SOURCE2=\${source}.sign"
> > - echo
> > "SOURCE_GPG=kernel.gpg:\${SOURCE2}"
> > + echo
> > "SOURCE_GPG=kernel.gpg:\${SOURCE2}:UPSTREAM_KEY"
> > echo "SOURCE2_URL=\${source_url}.sign"
> > ;;
> > *)
> > @@ -875,7 +875,7 @@
> > echo "SOURCE=\$source"
> > echo "SOURCE_URL=\$source_url"
> > echo "SOURCE2=\${source}.sign"
> > - echo
> > "SOURCE_GPG=kernel.gpg:\${SOURCE2}"
> > + echo
> > "SOURCE_GPG=kernel.gpg:\${SOURCE2}:UPSTREAM_KEY"
> > echo "SOURCE2_URL=\${source_url}.sign"
> > ;;
> > esac






Archive powered by MHonArc 2.6.24.

Top of Page