Skip to Content.
Sympa Menu

freetds - Re: [freetds] SQLGetData (bug in ODBC driver)

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: "ZIGLIO, Frediano, VF-IT" <Frediano.Ziglio AT vodafone.com>
  • To: "FreeTDS Development Group" <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] SQLGetData (bug in ODBC driver)
  • Date: Mon, 7 Jul 2008 09:51:16 +0200

> Suren A. Chilingaryan wrote:
> >
> > I have reworked a little bit my patch and have implemented
> unit tests.
> > Actually, in the old patch I have missed the comparison checking if
> > there is still data available. This comparison was again checking
> > processed number of bytes in output buffer against size of
> source. And
> > BINARY to CHAR conversion (which I said I haven't checked)
> was actually
> > wrong and even not needed.
> >
> > Additionally, I have implemented the CHAR to BINARY conversion for
> > SQLPutData. The unit test is checking both SQLGetData and
> SQLPutData
> > functionality.
>
> Hi Suren,
>
> Nice work. Thanks for the patch! I worked on it some myself
> to add the
> ODBC error messages and some other tidying up. Hope you like
> the result.
>
>
> I applied it to CVS HEAD. I thought it's better if Frediano
> takes a look
> at it before applying it to 0.82.
>

I seems the patch is not fully applied, prepare_query.c and unittest was not
patched.
Just an omission or did you decide to exclude part of the patch??

Frediano

Attachment: smime.p7s
Description: S/MIME cryptographic signature




Archive powered by MHonArc 2.6.24.

Top of Page