Subject: Re: [SM-Commit] GIT changes to master grimoire by Eric Sandall (bb2c85e517ee71b6ce602b0af6c72ab13d19fe39)
Date: Fri, 30 Nov 2007 12:21:52 +0100
On Friday 30 of November 2007 04:03:14 Eric Sandall wrote:
> > > +CFLAGS="-fno-strict-aliasing $CFLAGS" &&
> >
> > To nitpick: if the user set his custom CFLAGS to include
> > -fstrict-aliasing, I think this wouldn't work, the order is important. So
> > it would be better to have it like:
> > CFLAGS="$CFLAGS -fno-strict-aliasing"
>
> I thought of that, but our policy is to always have the user's CFLAGS
> override ours. However, for 'bug fixes' (such as this) we may want to
> override the user's choice.
>
> Do we want the user to always be right or the spell to always work? :)
I know about that policy, so my opinion should be obvious. ;)
A middle ground would be to detect -fstrict-aliasing and fail gracefully,
rather than later in some obscure way.
--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org
Attachment:
signature.asc Description: This is a digitally signed message part.