Subject: Re: [SM-Commit] GIT changes to master grimoire by Eric Sandall (bb2c85e517ee71b6ce602b0af6c72ab13d19fe39)
Date: Thu, 29 Nov 2007 19:03:14 -0800
On Thu, 2007-11-29 at 21:49 +0100, Jaka Kranjc wrote:
> On Thursday 29 of November 2007 19:40:18 Eric Sandall wrote:
> > GIT changes to master grimoire by Eric Sandall <sandalle AT sourcemage.org>:
> >
> > devel/jam/HISTORY | 4 ++++
> > devel/jam/PRE_BUILD | 1 +
> > 2 files changed, 5 insertions(+)
> >
> > New commits:
> > commit bb2c85e517ee71b6ce602b0af6c72ab13d19fe39
> > Author: Eric Sandall <sandalle AT sourcemage.org>
> > Commit: Eric Sandall <sandalle AT sourcemage.org>
> >
> > jam: Fix compilation with gcc 4.2 (Bug #14145)
>
> > +CFLAGS="-fno-strict-aliasing $CFLAGS" &&
> To nitpick: if the user set his custom CFLAGS to include -fstrict-aliasing,
> I
> think this wouldn't work, the order is important. So it would be better to
> have it like:
> CFLAGS="$CFLAGS -fno-strict-aliasing"
I thought of that, but our policy is to always have the user's CFLAGS
override ours. However, for 'bug fixes' (such as this) we may want to
override the user's choice.
Do we want the user to always be right or the spell to always work? :)