Skip to Content.
Sympa Menu

xom-interest - Re: [XOM-interest] why is Element.toString() final?

xom-interest AT lists.ibiblio.org

Subject: XOM API for Processing XML with Java

List archive

Chronological Thread  
  • From: Noam Tamim <noamtm AT gmail.com>
  • To: Steve Loughran <steve.loughran AT gmail.com>
  • Cc: xom-interest <xom-interest AT lists.ibiblio.org>
  • Subject: Re: [XOM-interest] why is Element.toString() final?
  • Date: Sat, 24 Dec 2005 11:39:23 +0200

In general you are right, and I wouldn't recommend it. However, from you
original post I understood that there is one particular nasty bug you have
now, and having a non-final Element.toString() would have made debugging it
easier. So I only recommend changing XOM for finding the bug, and then
reverting to the official build. Fix the bug when using the official build.

Noam.

On 12/21/05, Steve Loughran <steve.loughran AT gmail.com> wrote:
>
> On 12/21/05, Noam Tamim <noamtm AT gmail.com> wrote:
> > How about this plan:
> > 1. Get the XOM source;
> > 2. Remove the final;
> > 3. Build XOM;
> > 4. Add something that overrides Element.toString();
> > 5. Debug.
>
> Surely you mean
>
> 0. write one test that fails unless toString() works, another to check
> that non-overridden toString also works.; verify that test (1) fails
> and test (2) works.
> 1. Get the XOM source;
> 2. Remove the final;
> 3. Build XOM;
> 4. Add something that overrides Element.toString();
> 5. verify that both new tests work.
> 6. submit test+patches
>
> The danger there is once you start making your own build, it diverges,
> and I dont want to do that with Xom. Not yet, not over something so
> minor.
>




Archive powered by MHonArc 2.6.24.

Top of Page