Skip to Content.
Sympa Menu

freetds - Re: [freetds] incorrect fix in net.c

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: Frediano Ziglio <freddy77 AT gmail.com>
  • To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] incorrect fix in net.c
  • Date: Sun, 5 Apr 2009 15:48:48 +0200

2009/4/4 James K. Lowden <jklowden AT schemamania.org>:
> --- src/tds/net.c       16 Mar 2009 07:49:57 -0000      1.90
> +++ src/tds/net.c       27 Mar 2009 09:22:49 -0000      1.91
> @@ -700,7 +700,7 @@
>           continue;
>   }
>
> -  if (0 == nput || nput < 0 && sock_errno == EAGAIN)
> +  if (0 == nput || sock_errno == EAGAIN)
>           continue;
>
>
> The above change is incorrect.  sock_errno has no meaning unless
> send/write returns -1.
>

> 0 case is already handled, 0 case is tested by "0 == nput" so only < 0 is
> left (where sock_errno is valid)

freddy77




Archive powered by MHonArc 2.6.24.

Top of Page